Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide species list in model file #30

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Provide species list in model file #30

merged 2 commits into from
Oct 23, 2024

Conversation

kzinovjev
Copy link
Contributor

Allows to provide custom species list directly in the model file.

Also removed check for k_Z parameter, since now it is always present in the models.

@lohedges lohedges self-requested a review October 23, 2024 09:34
lohedges
lohedges approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@lohedges lohedges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I'll merge, then remove the redundant attributes and kwargs when users are happy.

@lohedges lohedges merged commit 7e54719 into chemle:main Oct 23, 2024
3 checks passed
@lohedges lohedges added the enhancement New feature or request label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lohedges lohedges lohedges approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kzinovjev @lohedges