Add support for basic error logging #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for basic diagnostic logging using loguru. This will make it much easier for users of the
sanderinterface to track down errors, since the current exceptions are cryptically hidden in theorc_job.datfile generated bysanderitself. By default, we now send diagnostic logs tosys.stderr. These can, instead, be sent to file by using the--log-fileorEMLE_LOG_FILEoption. For performance reasons we currently only log errors, but provide support for setting the log level via--log-levelorEMLE_LOG_LEVEL, i.e. we can add other messages in future. The existing energy file is now specified using--energy-fileorEMLE_ENERGY_FILE. The frequency at which energies are recorded is now controlled via--energy-frequencyorEMLE_ENERGY_FREQUENCY. The default is now set to zero, which indicates that energies shouldn't be written, i.e. the user needs to explicitly turn energy logging on.