Skip to content

Commit

Permalink
Adds tidyr as a suggests, disables lintr
Browse files Browse the repository at this point in the history
  • Loading branch information
garrettgman committed Dec 16, 2019
1 parent 6a6b21c commit d818814
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,4 @@ r_github_packages:

after_success:
- Rscript -e 'covr::codecov()'
- Rscript -e 'lintr::lint_package()'
# - Rscript -e 'lintr::lint_package()'
2 changes: 2 additions & 0 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ Imports:
glue,
checkmate,
testthat
Suggests:
tidyr
Remotes:
rstudio/learnr
URL: https://rstudio-education.github.io/gradethis/,
Expand Down
2 changes: 2 additions & 0 deletions tests/testthat/test_check_code.R
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,8 @@ test_that("Spot differences when pipes are involved", {
test_that("Spots differences in long calls", {
# original discussion here:
# https://github.com/rstudio-education/grader/issues/28

testthat::skip_if_not_installed("tidyr")

user <- quote(tidyr::gather(key = key, value = value, new_sp_m014:newrel_f65, na.rm = TRUE)) # nolint
solution <- quote(tidyr::gather(key = key, value = value, new_sp_m014:newrel_f65, na.rm = FALSE)) # nolint
Expand Down

0 comments on commit d818814

Please sign in to comment.