feat(di): nested impl traits #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes an `impl Trait` can be more than one level of generics deep. Or it might come from more than just the immediate children. This PR handles these cases correctly. It also expands the child dependency explicitly rather than calling a function to get the child dependencies. This is needed to prevent premature casting to `impl` types which leads to a compile error.
This makes more complex possible as shown by the new example.
This means adding support to understand the concrete type of transient dependencies. This is needed if any parent dependency of a transient is managed by the container.
We already know this is a box so no need for a helper function.
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles nested
impl Traits correctly as seen by the newly added example. Without these changes the example does not compile.