add basic PinyinVariant info #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Dec 22, 2024
src/editor/zhuyin_layout/pinyin.rs
Outdated
| #[default] | ||
| HanyuPinyin, | ||
| /// TODO: docs | ||
| /// [THL, 台灣華語羅馬拼音](https://pinyin.thl.tw/) |
There was a problem hiding this comment.
Don't use Chinese characters in comments unless you have to.
There was a problem hiding this comment.
/// [THL, taíwan huáyǔ luómǎ pinyin](https://pinyin.thl.tw/)
how about it?
There was a problem hiding this comment.
It looks better with title case Taíwan Huáyǔ Luómǎ Pinyin
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #667 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 42 42
Lines 8763 8763
=======================================
Hits 7874 7874
Misses 889 889 ☔ View full report in Codecov by Sentry. |
shawn111
force-pushed
the
PinyinVariant
branch
3 times, most recently
from
3e43992 to
273a9ec
Compare
shawn111
force-pushed
the
PinyinVariant
branch
from
273a9ec to
365897a
Compare
kanru
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some information about PinyinVariant