Simplify CMake build flags #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanru
reviewed
May 22, 2024
CMake will set `NDEBUG` automatically: https://github.com/Kitware/CMake/blob/50252733c46025d7086d7b0ea6daef04e0c5346f/Modules/Platform/Windows-MSVC.cmake#L488-L491 MSVC will set `_DEBUG` automatically: https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170#microsoft-specific-predefined-macros
Those flags are mostly the same as the ones used by CMake. And for those flags that are different, extract them out. * https://github.com/Kitware/CMake/blob/50252733c46025d7086d7b0ea6daef04e0c5346f/Modules/Platform/Windows-MSVC.cmake#L488-L491 * https://learn.microsoft.com/en-us/cpp/build/reference/opt-optimizations?view=msvc-170
The new flag should come after in order to override previous flag.
kanru
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html#variable:CMAKE_MSVC_RUNTIME_LIBRARY
CMake will set
NDEBUGautomatically:https://github.com/Kitware/CMake/blob/50252733c46025d7086d7b0ea6daef04e0c5346f/Modules/Platform/Windows-MSVC.cmake#L488-L491
MSVC will set
_DEBUGautomatically:https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170#microsoft-specific-predefined-macros
Those flags are mostly the same as the ones used by CMake. And for those flags that are
different, extract them out.
The new flag should come after in order to override previous flag.