Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property based route filter #90

Merged
merged 6 commits into from
Mar 28, 2024
Merged

Conversation

nicolocarpignoli
Copy link
Member

@nicolocarpignoli nicolocarpignoli commented Mar 25, 2024

Introducing a property based filters for object route matching.

Copy link
Contributor

@fquffio fquffio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit tests are failing, but I'm afraid that's due to a change in the upstream bedita/core fixtures. We need to adapt ours to avoid duplicate unique keys. 😞

src/Routing/Route/ObjectRoute.php Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 22.72727% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 15.4%. Comparing base (a39a234) to head (811f6d8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #90     +/-   ##
=========================================
+ Coverage     15.3%   15.4%   +0.1%     
- Complexity     502     506      +4     
=========================================
  Files           33      33             
  Lines         1477    1490     +13     
=========================================
+ Hits           226     230      +4     
- Misses        1251    1260      +9     
Files Coverage Δ
src/View/Helper/DateRangesHelper.php 68.5% <100.0%> (+2.5%) ⬆️
src/Routing/Route/ObjectRoute.php 0.0% <0.0%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a39a234...811f6d8. Read the comment docs.

@nicolocarpignoli nicolocarpignoli merged commit 0c7cd90 into main Mar 28, 2024
14 checks passed
@nicolocarpignoli nicolocarpignoli deleted the feat/extend-route-filters branch March 28, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants