Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTML minification with htmlnano #168

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Support HTML minification with htmlnano #168

merged 2 commits into from
Mar 5, 2024

Conversation

edoardocavazza
Copy link
Member

This PR adds support for HTML minification through the htmlnano module. Please note that htmlnano is not bundled with the plugin, users will need to install the dependency themselves in order to enable HTML minification.

It should fix #158.

Copy link

changeset-bot bot commented Mar 5, 2024

🦋 Changeset detected

Latest commit: 550fdcb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chialab/esbuild-plugin-html Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 91.54%. Comparing base (d745e14) to head (550fdcb).

Files Patch % Lines
packages/esbuild-plugin-html/lib/index.js 73.33% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   91.64%   91.54%   -0.10%     
==========================================
  Files          36       36              
  Lines        5865     5892      +27     
==========================================
+ Hits         5375     5394      +19     
- Misses        490      498       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edoardocavazza edoardocavazza merged commit 0bf6ad9 into main Mar 5, 2024
6 of 8 checks passed
@edoardocavazza edoardocavazza deleted the minify-html branch March 5, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimize html
1 participant