Clean up docc broken link + tests (#107) 🚀

* Clean up static property + docc broken link * Added linux tests
chicio · Oct 24, 2024 · a93decf · a93decf
1 parent 4f94cc3
commit a93decf
Show file tree

Hide file tree

Showing 43 changed files with 15 additions and 248 deletions.
diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml
@@ -22,6 +22,7 @@ jobs:
       - name: Build Linux framework
         run: |
            swift build
+           swift test
       - name: Build Linux Demo
         run: |
             cd Demo/Demo\ Ubuntu

diff --git a/Demo/Demo.xcodeproj/project.pbxproj b/Demo/Demo.xcodeproj/project.pbxproj
@@ -379,8 +379,9 @@
 		452832E72044D28E00458375 /* Project object */ = {
 			isa = PBXProject;
 			attributes = {
+				BuildIndependentTargetsInParallel = YES;
 				LastSwiftUpdateCheck = 1600;
-				LastUpgradeCheck = 1200;
+				LastUpgradeCheck = 1600;
 				ORGANIZATIONNAME = "Fabrizio Duroni";
 				TargetAttributes = {
 					45966C942CBACF5000F841E7 = {
@@ -583,6 +584,7 @@
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				CODE_SIGN_IDENTITY = "Mac Developer";
 				COPY_PHASE_STRIP = NO;
+				DEAD_CODE_STRIPPING = YES;
 				DEBUG_INFORMATION_FORMAT = dwarf;
 				ENABLE_STRICT_OBJC_MSGSEND = YES;
 				ENABLE_TESTABILITY = YES;
@@ -645,6 +647,7 @@
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				CODE_SIGN_IDENTITY = "Mac Developer";
 				COPY_PHASE_STRIP = NO;
+				DEAD_CODE_STRIPPING = YES;
 				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
 				ENABLE_NS_ASSERTIONS = NO;
 				ENABLE_STRICT_OBJC_MSGSEND = YES;
@@ -689,6 +692,7 @@
 					"@executable_path/Frameworks",
 				);
 				LOCALIZATION_PREFERS_STRING_CATALOGS = YES;
+				MACOSX_DEPLOYMENT_TARGET = 11.0;
 				MARKETING_VERSION = 1.0;
 				MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
 				MTL_FAST_MATH = YES;
@@ -726,6 +730,7 @@
 					"@executable_path/Frameworks",
 				);
 				LOCALIZATION_PREFERS_STRING_CATALOGS = YES;
+				MACOSX_DEPLOYMENT_TARGET = 11.0;
 				MARKETING_VERSION = 1.0;
 				MTL_FAST_MATH = YES;
 				PRODUCT_BUNDLE_IDENTIFIER = "it.chicio.Demo-tvOS";
@@ -766,6 +771,7 @@
 					"@executable_path/Frameworks",
 				);
 				LOCALIZATION_PREFERS_STRING_CATALOGS = YES;
+				MACOSX_DEPLOYMENT_TARGET = 11.0;
 				MARKETING_VERSION = 1.0;
 				MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
 				MTL_FAST_MATH = YES;
@@ -806,6 +812,7 @@
 					"@executable_path/Frameworks",
 				);
 				LOCALIZATION_PREFERS_STRING_CATALOGS = YES;
+				MACOSX_DEPLOYMENT_TARGET = 11.0;
 				MARKETING_VERSION = 1.0;
 				MTL_FAST_MATH = YES;
 				PRODUCT_BUNDLE_IDENTIFIER = "it.chicio.Demo-iOS";
@@ -830,6 +837,7 @@
 				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;
 				CURRENT_PROJECT_VERSION = 1;
+				DEAD_CODE_STRIPPING = YES;
 				DEVELOPMENT_ASSET_PATHS = "\"Demo macOS/Preview Content\"";
 				DEVELOPMENT_TEAM = 5Y4K7JX2AU;
 				ENABLE_HARDENED_RUNTIME = YES;
@@ -867,6 +875,7 @@
 				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;
 				CURRENT_PROJECT_VERSION = 1;
+				DEAD_CODE_STRIPPING = YES;
 				DEVELOPMENT_ASSET_PATHS = "\"Demo macOS/Preview Content\"";
 				DEVELOPMENT_TEAM = 5Y4K7JX2AU;
 				ENABLE_HARDENED_RUNTIME = YES;
@@ -914,6 +923,7 @@
 					"@executable_path/Frameworks",
 				);
 				LOCALIZATION_PREFERS_STRING_CATALOGS = YES;
+				MACOSX_DEPLOYMENT_TARGET = 11.0;
 				MARKETING_VERSION = 1.0;
 				MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
 				MTL_FAST_MATH = YES;
@@ -953,6 +963,7 @@
 					"@executable_path/Frameworks",
 				);
 				LOCALIZATION_PREFERS_STRING_CATALOGS = YES;
+				MACOSX_DEPLOYMENT_TARGET = 11.0;
 				MARKETING_VERSION = 1.0;
 				MTL_FAST_MATH = YES;
 				PRODUCT_BUNDLE_IDENTIFIER = "it.chicio.Demo-watchOS";

diff --git a/ID3TagEditor.xcodeproj/project.pbxproj b/ID3TagEditor.xcodeproj/project.pbxproj
@@ -50,7 +50,6 @@
 		455CF98B2340C4E1004C880A /* PULL_REQUEST_TEMPLATE.md */ = {isa = PBXFileReference; lastKnownFileType = net.daringfireball.markdown; path = PULL_REQUEST_TEMPLATE.md; sourceTree = "<group>"; };
 		45925B99253B4EB4001C8D4F /* codecov.yml */ = {isa = PBXFileReference; lastKnownFileType = text.yaml; path = codecov.yml; sourceTree = "<group>"; };
 		45925B9A253B5277001C8D4F /* codecov.yml */ = {isa = PBXFileReference; lastKnownFileType = text.yaml; path = codecov.yml; sourceTree = "<group>"; };
-		459ABE822CBBCFAC00DCCD69 /* ID3TagEditor.docc */ = {isa = PBXFileReference; lastKnownFileType = folder.documentationcatalog; path = ID3TagEditor.docc; sourceTree = "<group>"; };
 		45AB7193204AD842004A2239 /* Package.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Package.swift; sourceTree = "<group>"; };
 		45AB7194204AD842004A2239 /* LICENSE.md */ = {isa = PBXFileReference; lastKnownFileType = net.daringfireball.markdown; path = LICENSE.md; sourceTree = "<group>"; };
 		45AB7195204AD842004A2239 /* README.md */ = {isa = PBXFileReference; lastKnownFileType = net.daringfireball.markdown; path = README.md; sourceTree = "<group>"; };
@@ -193,7 +192,6 @@
 		452831BB2044C40700458375 = {
 			isa = PBXGroup;
 			children = (
-				459ABE822CBBCFAC00DCCD69 /* ID3TagEditor.docc */,
 				45925B99253B4EB4001C8D4F /* codecov.yml */,
 				45541C25205999A20025A8BF /* CHANGELOG.md */,
 				455CF98A2340C4D7004C880A /* CODE_OF_CONDUCT.md */,
@@ -1022,7 +1020,7 @@
 				SKIP_INSTALL = YES;
 				SWIFT_VERSION = 6.0;
 				TARGETED_DEVICE_FAMILY = 3;
-				TVOS_DEPLOYMENT_TARGET = 12.0;
+				TVOS_DEPLOYMENT_TARGET = 15.0;
 			};
 			name = Debug;
 		};
@@ -1056,7 +1054,7 @@
 				SKIP_INSTALL = YES;
 				SWIFT_VERSION = 6.0;
 				TARGETED_DEVICE_FAMILY = 3;
-				TVOS_DEPLOYMENT_TARGET = 12.0;
+				TVOS_DEPLOYMENT_TARGET = 15.0;
 				VALIDATE_PRODUCT = YES;
 			};
 			name = Release;

diff --git a/Tests/Acceptance/ID3TagEditorAcceptanceTest.swift b/Tests/Acceptance/ID3TagEditorAcceptanceTest.swift
@@ -895,33 +895,6 @@ struct ID3TagEditorAcceptanceTest {
         #expect((id3Tag?.frames[.comment(.eng)] as? ID3FrameWithLocalizedContent)?.contentDescription == "")
         #expect((id3Tag?.frames[.comment(.eng)] as? ID3FrameWithLocalizedContent)?.content == "ÜberStandard - UberNet.org")
     }
-
-    static let allTests = [
-        ("testFailWrongFilePathFilePath", testFailWrongFilePathFilePath),
-        ("testReadTagV2", testReadTagV2),
-        ("testParseTagV3", testParseTagV3),
-        ("testReadTagV4", testReadTagV4),
-        ("testReadTagV4WithImage", testReadTagV4WithImage),
-        ("testReadAsMp3", testReadAsMp3),
-        ("testReadCorruptedFile", testReadCorruptedFile),
-        ("testReadUtf16String", testReadUtf16String),
-        ("testWriteTagV2", testWriteTagV2),
-        ("testWriteTagV3WhenItAlreadyExists", testWriteTagV3WhenItAlreadyExists),
-        ("testWriteTagV3WithJpg", testWriteTagV3WithJpg),
-        ("testWriteTagV3WithPng", testWriteTagV3WithPng),
-        ("testWriteTagV3WithCustomPathThatDoesNotExists", testWriteTagV3WithCustomPathThatDoesNotExists),
-        ("testWriteTagV3WithSamePath", testWriteTagV3WithSamePath),
-        ("testWriteTagV3WithAdditionalData", testWriteTagV3WithAdditionalData),
-        ("testWriteTagV3ToMp3AsData", testWriteTagV3ToMp3AsData),
-        ("testWriteTagV4", testWriteTagV4),
-        ("testWriteTagV4WithPng", testWriteTagV4WithPng),
-        ("testWriteTagV4SynchsafeIntegers", testWriteTagV4SynchsafeIntegers),
-        ("testWriteUnsynchronisedLyrics", testWriteUnsynchronisedLyrics),
-        ("testWriteNewFramesV2", testWriteNewFramesV2),
-        ("testWriteNewFramesV3", testWriteNewFramesV3),
-        ("testWriteNewFramesV4", testWriteNewFramesV4),
-        ("testCommentWithUTF8EncodingAndNoContentDescription", testCommentWithUTF8EncodingAndNoContentDescription)
-    ]
 }
 
 // swiftlint:enable type_body_length

diff --git a/Tests/Acceptance/ID3TagEditorWriteReadAcceptanceTest.swift b/Tests/Acceptance/ID3TagEditorWriteReadAcceptanceTest.swift
@@ -502,12 +502,6 @@ struct ID3TagEditorWriteReadAcceptanceTest {
         #expect(tagReader.iTunesPodcastID() == "PodcastID V4")
         #expect(tagReader.iTunesPodcastKeywords() == "PodcastKeywords V4")
     }
-
-    static let allTests = [
-        ("testReadWritev2", testReadWritev2),
-        ("testReadWritev3", testReadWritev3),
-        ("testReadWritev4", testReadWritev4)
-    ]
 }
 
 // swiftlint:enable type_body_length

diff --git a/Tests/Common/PaddingAdderUsingNullCharTest.swift b/Tests/Common/PaddingAdderUsingNullCharTest.swift
@@ -16,8 +16,4 @@ struct PaddingAdderUsingNullCharTest {
 
         #expect(contentWithPadding == [0x1, 0x1, 0x0])
     }
-
-    static let allTests = [
-        ("testAddPadding", testAddPadding)
-    ]
 }
diff --git a/Tests/Common/PaddingRemoverUsingTrimming.swift b/Tests/Common/PaddingRemoverUsingTrimming.swift
@@ -15,8 +15,4 @@ struct PaddingRemoverUsingTrimmingTest {
                 PaddingRemoverUsingTrimming().removeFrom(string: "\0\0\0simple string\0\0\0")
         )
     }
-
-    static let allTests = [
-        ("testRemovePadding", testRemovePadding)
-    ]
 }
diff --git a/Tests/Common/UInt32ToByteArrayAdapterUsingUnsafePointerTest.swift b/Tests/Common/UInt32ToByteArrayAdapterUsingUnsafePointerTest.swift
@@ -15,8 +15,4 @@ struct UInt32ToByteArrayAdapterUsingUnsafePointerTest {
             [0x11, 0x22, 0x33, 0x44]
         )
     }
-
-    static let allTests = [
-        ("testAdapt32BitUnsignedInteger", testAdapt32BitUnsignedInteger)
-    ]
 }
diff --git a/Tests/Create/ID3AttachedPicturesFrameCreatorsTest.swift b/Tests/Create/ID3AttachedPicturesFrameCreatorsTest.swift
@@ -146,15 +146,6 @@ struct ID3AttachedPicturesFramesCreatorTest {
                  0x00, 0x04, 0x00, 0x10, 0x10]
         )
     }
-
-    static let allTests = [
-        ("frameCreationWithJpgForVersion2", frameCreationWithJpgForVersion2),
-        ("frameCreationWithJpgForVersion3", frameCreationWithJpgForVersion3),
-        ("frameCreationWithPngForAnotherTypeOfCover", frameCreationWithPngForAnotherTypeOfCover),
-        ("frameCreationWithPngForVersion2", frameCreationWithPngForVersion2),
-        ("frameCreationWithPngForVersion3", frameCreationWithPngForVersion3),
-        ("noFrameCreationWhenThereIsNoImage", noFrameCreationWhenThereIsNoImage)
-    ]
 }
 
 

diff --git a/Tests/Create/ID3DiscPositionFrameCreatorTest.swift b/Tests/Create/ID3DiscPositionFrameCreatorTest.swift
@@ -43,9 +43,4 @@ struct ID3DiscPositionFrameCreatorTest {
 
         #expect(newTagBytes == newFrameBytes)
     }
-
-    static let allTests = [
-        ("testFrameCreationWhenThereIsADiscPosition", testFrameCreationWhenThereIsADiscPosition),
-        ("testNoFrameCreationWhenThereIsNoDiscPosition", testNoFrameCreationWhenThereIsNoDiscPosition)
-    ]
 }
diff --git a/Tests/Create/ID3FrameContentSizeCalculatorTest.swift b/Tests/Create/ID3FrameContentSizeCalculatorTest.swift
@@ -39,9 +39,4 @@ struct ID3FrameContentSizeCalculatorTest {
 
         #expect(size == [0x3, 0x2])
     }
-
-    static let allTests = [
-        ("testContentCalculateSizeForVersion2", testContentCalculateSizeForVersion2),
-        ("testContentCalculateSizeForVersion3", testContentCalculateSizeForVersion3)
-    ]
 }
diff --git a/Tests/Create/ID3FrameFlagsCreatorTest.swift b/Tests/Create/ID3FrameFlagsCreatorTest.swift
@@ -16,9 +16,4 @@ struct ID3FrameFlagsCreatorTest {
     @Test func testFlagsForVersion2() {
         #expect(ID3FrameFlagsCreator().createFor(version: .version2) == [])
     }
-
-    static let allTests = [
-        ("testFlagsForVersion2", testFlagsForVersion2),
-        ("testFlagsForVersion3", testFlagsForVersion3)
-    ]
 }
diff --git a/Tests/Create/ID3FrameFromStringContentCreatorTest.swift b/Tests/Create/ID3FrameFromStringContentCreatorTest.swift
@@ -23,8 +23,4 @@ struct ID3FrameFromStringContentCreatorTest {
 
         #expect(frameBytes == [0x01, 0x02] + "test".utf16ToBytes)
     }
-
-    static let allTests = [
-        ("testCreatorFrameFromStringContent", testCreatorFrameFromStringContent)
-    ]
 }
diff --git a/Tests/Create/ID3FrameHeaderCreatorTest.swift b/Tests/Create/ID3FrameHeaderCreatorTest.swift
@@ -19,8 +19,4 @@ struct ID3FrameHeaderCreatorTest {
 
         #expect(header == [UInt8]("USLT".utf8) + [0x11, 0x00])
     }
-
-    static let allTests = [
-        ("create", create)
-    ]
 }
diff --git a/Tests/Create/ID3FrameWithIntegerContentCreatorTest.swift b/Tests/Create/ID3FrameWithIntegerContentCreatorTest.swift
@@ -45,9 +45,4 @@ struct ID3FrameWithIntegerContentCreatorTest {
 
         #expect(newTagBytes == newFrameBytes)
     }
-
-    static let allTests = [
-        ("testNoFrameCreationWhenThereIsNoContent", testNoFrameCreationWhenThereIsNoContent),
-        ("testFrameCreationWhenThereIsContent", testFrameCreationWhenThereIsContent)
-    ]
 }
diff --git a/Tests/Create/ID3FrameWithStringContentCreatorTest.swift b/Tests/Create/ID3FrameWithStringContentCreatorTest.swift
@@ -44,9 +44,4 @@ struct ID3FrameWithStringContentCreatorTest {
 
         #expect(newTagBytes == newFrameBytes)
     }
-
-    static let allTests = [
-        ("testNoFrameCreationWhenThereIsNoFrameData", testNoFrameCreationWhenThereIsNoFrameData),
-        ("testFrameCreationWhenThereIsFrameData", testFrameCreationWhenThereIsFrameData)
-    ]
 }
diff --git a/Tests/Create/ID3FramesWithLocalizedContentCreatorTest.swift b/Tests/Create/ID3FramesWithLocalizedContentCreatorTest.swift
@@ -41,9 +41,4 @@ struct ID3FramesWithLocalizedContentCreatorTest {
             ))
             .build()
     }
-
-    static let allTests = [
-        ("testNothingIsCreatedWheLyricsDataIsNotSet", testNothingIsCreatedWheLyricsDataIsNotSet),
-        ("testCreateFrameForValidData", testCreateFrameForValidData)
-    ]
 }
diff --git a/Tests/Create/ID3GenreFrameCreatorTest.swift b/Tests/Create/ID3GenreFrameCreatorTest.swift
@@ -41,9 +41,4 @@ struct ID3GenreFrameCreatorTest {
 
         #expect(newTagBytes == newFrameBytes)
     }
-
-    static let allTests = [
-        ("testFrameCreationWhenThereIsAGenre", testFrameCreationWhenThereIsAGenre),
-        ("testNoFrameCreationWhenThereIsNoGenre", testNoFrameCreationWhenThereIsNoGenre)
-    ]
 }
diff --git a/Tests/Create/ID3ISO88591StringToByteAdapterTest.swift b/Tests/Create/ID3ISO88591StringToByteAdapterTest.swift
@@ -21,8 +21,4 @@ struct ID3ISO88591StringToByteAdapterTest {
 
         #expect(bytes == ENCODING + STRING)
     }
-
-    static let allTests = [
-        ("testEncodeStringToISO88591WithEncodingByte", testEncodeStringToISO88591WithEncodingByte)
-    ]
 }
diff --git a/Tests/Create/ID3LocalizedFrameCreatorTest.swift b/Tests/Create/ID3LocalizedFrameCreatorTest.swift
@@ -75,10 +75,4 @@ struct ID3LocalizedFrameCreatorTest {
                         0xFE, 0x6C, 0x00, 0x79, 0x00, 0x72, 0x00, 0x69, 0x00, 0x63, 0x00, 0x73,
                         0x00])
     }
-
-    static let allTests = [
-        ("testCreatev2", testCreatev2),
-        ("testCreatev3", testCreatev3),
-        ("testCreatev4", testCreatev4)
-    ]
 }
diff --git a/Tests/Create/ID3RecordingDateTimeFrameCreatorTest.swift b/Tests/Create/ID3RecordingDateTimeFrameCreatorTest.swift
@@ -32,9 +32,4 @@ struct ID3RecordingDateTimeFrameCreatorTest {
         #expect(timestampCreator.createFromRecordingDateTimeHasBeenCalled)
         #expect(newTagBytes == newFrameBytes)
     }
-
-    static let allTests = [
-        ("testFrameCreationWhenThereIsACompleteRecordingDateTime",
-         testFrameCreationWhenThereIsACompleteRecordingDateTime)
-    ]
 }
diff --git a/Tests/Create/ID3RecordingDayMonthFrameCreatorTest.swift b/Tests/Create/ID3RecordingDayMonthFrameCreatorTest.swift
@@ -60,10 +60,4 @@ struct ID3RecordingDayMonthFrameCreatorTest {
 
         #expect(newTagBytes == newFrameBytes)
     }
-
-    static let allTests = [
-        ("testFrameCreationWhenThereIsADayAndAMonth", testFrameCreationWhenThereIsADayAndAMonth),
-        ("testNoFrameCreationWhenThereIsNoDay", testNoFrameCreationWhenThereIsNoDay),
-        ("testNoFrameCreationWhenThereIsNoMonth", testNoFrameCreationWhenThereIsNoMonth)
-    ]
 }
diff --git a/Tests/Create/ID3TagCreatorTest.swift b/Tests/Create/ID3TagCreatorTest.swift
@@ -48,10 +48,4 @@ struct ID3TagCreatorTest {
                 )
         )
     }
-
-    static let allTests = [
-        ("testGenerateValidData", testGenerateValidData),
-        ("testNoValidFrameData", testNoValidFrameData),
-        ("testTagTooBig", testTagTooBig)
-    ]
 }
diff --git a/Tests/Create/ID3TimestampCreatorTest.swift b/Tests/Create/ID3TimestampCreatorTest.swift
@@ -56,13 +56,4 @@ struct ID3TimestampCreatorTest {
 
         #expect(timestampCreator.createFrom(recordingDateTime: recordingTime) == nil)
     }
-
-    static let allTests = [
-        ("testCreateTimestampCorrectly", testCreateTimestampCorrectly),
-        ("testNilDay", testNilDay),
-        ("testNilMonth", testNilMonth),
-        ("testNilYear", testNilYear),
-        ("testNilHour", testNilHour),
-        ("testNilMinute", testNilMinute)
-    ]
 }
diff --git a/Tests/Create/ID3TrackPositionFrameCreatorTest.swift b/Tests/Create/ID3TrackPositionFrameCreatorTest.swift
@@ -41,9 +41,4 @@ struct ID3TrackPositionCreatorTest {
 
         #expect(newTagBytes == newFrameBytes)
     }
-
-    static let allTests = [
-        ("testFrameCreationWhenThereIsATrackPosition", testFrameCreationWhenThereIsATrackPosition),
-        ("testNoFrameCreationWhenThereIsNoTrackPosition", testNoFrameCreationWhenThereIsNoTrackPosition)
-    ]
 }
diff --git a/Tests/Create/ID3UTF16StringToByteAdapterTest.swift b/Tests/Create/ID3UTF16StringToByteAdapterTest.swift
@@ -22,8 +22,4 @@ struct ID3UTF16StringToByteAdapterTest {
 
         #expect(bytes == ENCODING + BOM + STRING)
     }
-
-    static let allTests = [
-        ("testEncodeStringToUTF16WithEncodingByte", testEncodeStringToUTF16WithEncodingByte)
-    ]
 }