Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better colours for terrain #68

Open
chevreaux opened this issue Apr 3, 2023 · 9 comments
Open

Better colours for terrain #68

chevreaux opened this issue Apr 3, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@chevreaux
Copy link
Contributor

seriously i can barely tell the difference between walkable, ramp, and height 0. not having it bit strictly grayscale would help.
I will try out some palettes and post here

@chevreaux
Copy link
Contributor Author

chevreaux commented Apr 3, 2023

here is an example
image
VS
image

@ngyikp ngyikp added the enhancement New feature or request label Apr 3, 2023
@ngyikp
Copy link
Member

ngyikp commented Apr 3, 2023

One caveat to consider: What should we do with old images with old palettes?

Colors from the original level editor: https://www.youtube.com/watch?v=H0n3bTKX4ZU


We could also make the colors customizable.

@PlasmaFlare
Copy link

PlasmaFlare commented Apr 3, 2023

One caveat to consider: What should we do with old images with old palettes?

If the concern is that people who previously have stored terrain images (from the "Edit Terrain" button) suddenly find that their images are incompatible, I personally don't think it's much of an issue.

From a user perspective, I see the downloaded terrain images as temporary; it only serves as a medium to update level_data, which is the thing I would want to actually store. So whether or not the palette changes, it doesn't matter to me since it's not what I'll be storing in the long run.

But I'm just speaking for myself. I'm not sure about anyone else.

@chevreaux
Copy link
Contributor Author

I think it's a fair concern since someone might have some WIPs that they would no longer be able to upload. So a patch to support backwards compatibility would be good.

BUT, since the userbase is small, this might not actually affect anyone, and if it does we can just ask them to make the changes manually on their end. Save us some work.

@VanillaCold
Copy link

Hm, what about just having an option to use either the vanilla terrain colours or custom ones when importing a map?

@chevreaux
Copy link
Contributor Author

I don't think the current colours have any basis in vanilla, I think they were arbitrarily chosen.

@ngyikp
Copy link
Member

ngyikp commented Apr 3, 2023

If we use Greg's own colors, this is what it looks like:
image

But we'll probably not use that, the colors look quite jarring (why pink for the sky??)

Hm, what about just having an option to use either the vanilla terrain colours or custom ones when importing a map?

That's one method I thought of, you can choose the palette when importing, I'm trying to see if there's any need for that (so far, none)

I don't think the current colours have any basis in vanilla, I think they were arbitrarily chosen.

Yeah, I randomly chose the colors 🥲

@ngyikp
Copy link
Member

ngyikp commented Apr 4, 2023

Another idea is to change the colors on the main editor UI (as we can change this at any time without issue), but the export terrain can remain the old colors for compatibility or until we're finalized what colors we want.

ngyikp added a commit that referenced this issue Apr 10, 2023
Colors for export will remain the same for compatibility

Now we can change the colors on the editor without much issue

Ref #68
@ngyikp
Copy link
Member

ngyikp commented May 29, 2023

Is this resolved now that the terrain colors have changed? I think we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants