added comment & cleanup

chili-publish · Dec 17, 2024 · ccd48b0 · ccd48b0
1 parent de92116
commit ccd48b0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/components/pagesPanel/Pages.tsx b/src/components/pagesPanel/Pages.tsx
@@ -38,6 +38,12 @@ function Pages({ pages, activePageId, pagesToRefresh, setPagesToRefresh }: Pages
         return awaitedArray as PageSnapshot[];
     }, []);
 
+    /**
+     * by attaching listeners here and not in ShortcutProvider.tsx,
+     * 'pages' prop that gets populated via 'onPagesChanged' subscriber,
+     * will not trigger rerenders of ShortcutProvider's children,
+     * causing multiple query refectch in useMediaDetails
+     */
     const { handleSelectPage } = useAttachArrowKeysListener({ pages, activePageId });
 
     useEffect(() => {

diff --git a/src/tests/contexts/ShortcutProvider.test.tsx b/src/tests/contexts/ShortcutProvider.test.tsx
@@ -16,6 +16,7 @@ describe('ShortcutProvider', () => {
     mockSDK.canvas.setZoomPercentage = jest.fn().mockImplementation().mockReturnValue({ success: true, code: 200 });
 
     window.StudioUISDK = mockSDK;
+
     it('triggers the sandbox toggle shortcut', async () => {
         const user = userEvent.setup();
         const onSandboxModeToggleFn = jest.fn();