Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Correctly zoom to page when layout intent changes #230

Merged
merged 1 commit into from
Nov 20, 2024
Merged

[Fix] Correctly zoom to page when layout intent changes #230

merged 1 commit into from
Nov 20, 2024

Conversation

alexandraFlavia9
Copy link
Contributor

This PR fixes zoom to page when layout changes

Related tickets

Screenshots

@alexandraFlavia9 alexandraFlavia9 requested a review from a team as a code owner November 20, 2024 07:56
@github-actions GitHub Actions
Copy link
Contributor

PR can be checked at https://stgrafxstudiodevpublic.blob.core.windows.net/studio-ui/pr_builds/230/index.html

@github-actions GitHub Actions
Copy link
Contributor

Coverage report can be checked at https://stgrafxstudiodevpublic.blob.core.windows.net/studio-ui/coverage_reports/230/coverage.html

@github-actions GitHub Actions
Copy link
Contributor

Test Results

123 tests   121 ✅  1m 32s ⏱️
 28 suites    2 💤
  1 files      0 ❌

Results for commit 85022d2.

@github-actions GitHub Actions
Copy link
Contributor

PR bundle size is 1.028 MB and 75.753 KB more than limit.

@alexandraFlavia9 alexandraFlavia9 added the Ready for QA Defines that PR is ready for QA label Nov 20, 2024
@alexandraFlavia9 alexandraFlavia9 merged commit c3cbc3f into main Nov 20, 2024
11 checks passed
@alexandraFlavia9 alexandraFlavia9 deleted the fix/zoom-to-page-on-layout-change branch November 20, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psamusev psamusev psamusev approved these changes

@abdelhalimkhouas abdelhalimkhouas abdelhalimkhouas approved these changes

@pietervp pietervp Awaiting requested review from pietervp pietervp is a code owner automatically assigned from chili-publish/react

@smereuta smereuta Awaiting requested review from smereuta smereuta is a code owner automatically assigned from chili-publish/react

Assignees
No one assigned
Labels
No JIRA ticket Ready for QA Defines that PR is ready for QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandraFlavia9 @psamusev @abdelhalimkhouas