Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Bump sdk version for realease #252

Merged
merged 2 commits into from
Dec 18, 2024
Merged

[Fix] Bump sdk version for realease #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90d5450
bump sdk version
abdelhalimkhouas Dec 18, 2024
a157622
Fix failing tests
brapoprod Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
},
"dependencies": {
"@chili-publish/grafx-shared-components": "^0.88.10",
"@chili-publish/studio-sdk": "^1.17.2-rc.2",
"@chili-publish/studio-sdk": "^1.18.0",
"@babel/preset-env": "^7.25.3",
"@fortawesome/fontawesome-svg-core": "^6.7.1",
"@fortawesome/pro-light-svg-icons": "^6.7.1",
Expand Down
2 changes: 1 addition & 1 deletion src/tests/VariablesComponents.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
,
</UiThemeProvider>,
);
const variable = await waitFor(() => screen.getByText(variables[0].label));
const variable = await waitFor(() => screen.getByText(variables[0].label!));

Check warning on line 55 in src/tests/VariablesComponents.test.tsx

View workflow job for this annotation

GitHub Actions / build (20) 

Forbidden non-null assertion
expect(variable).toBeInTheDocument();
});

Expand Down
4 changes: 2 additions & 2 deletions src/tests/components/variablesComponents/booleanVariable/BooleanVariable.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
</UiThemeProvider>,
);

const variableLabel = screen.queryByText(booleanVar.label);
const variableLabel = screen.queryByText(booleanVar.label!);

Check warning on line 26 in src/tests/components/variablesComponents/booleanVariable/BooleanVariable.test.tsx

View workflow job for this annotation

GitHub Actions / build (20) 

Forbidden non-null assertion
// the label is empty string won't be rendered
expect(variableLabel).toBeNull();
});
Expand All @@ -38,7 +38,7 @@
</UiThemeProvider>,
);

expect(screen.getByText(booleanVar.label)).toBeInTheDocument();
expect(screen.getByText(booleanVar.label!)).toBeInTheDocument();

Check warning on line 41 in src/tests/components/variablesComponents/booleanVariable/BooleanVariable.test.tsx

View workflow job for this annotation

GitHub Actions / build (20) 

Forbidden non-null assertion
});
it('should display label as variable name if label does not exist', () => {
const booleanVar = {
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1312,10 +1312,10 @@
resolved "https://npm.pkg.github.com/download/@chili-publish/grafx-shared-components/0.88.10/93c899d0312b1046ef236443e5b7287960a2ec99#93c899d0312b1046ef236443e5b7287960a2ec99"
integrity sha512-27J0spClNrVb9ADhTrTLJskLdo5Qr0bA7AnkjPd9z2NI0q4NgJAs0hwkQkGV6/+hLU1vRWccZPovEzjPXmntdg==

"@chili-publish/studio-sdk@^1.17.2-rc.2":
version "1.17.2-rc.2"
resolved "https://npm.pkg.github.com/download/@chili-publish/studio-sdk/1.17.2-rc.2/83fb011c4f7d955f6f4911f43fc7328436b638ed#83fb011c4f7d955f6f4911f43fc7328436b638ed"
integrity sha512-w/tf3DilXLJKadsVkQGLePZshVOEjC+CvIAmwZYb1lWMuTFOBG619zH5PX5RTGfetcjJOahW79qVOCBiA9o/Lg==
"@chili-publish/studio-sdk@^1.18.0":
version "1.18.0"
resolved "https://npm.pkg.github.com/download/@chili-publish/studio-sdk/1.18.0/d55d0a038e48eecb47030fc02794f0d1142a24fc#d55d0a038e48eecb47030fc02794f0d1142a24fc"
integrity sha512-evIpPdr/eesqpdxKnkXKQ6khgx9NhZkYisortacFAEQfnuWUNlroNOMZA3DbxaDo9Dkd7gS6MMuF/HqXeFvDCg==
dependencies:
penpal "6.1.0"

Expand Down
Loading