Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat][WRS-2227] Add Error/Empty state for configured data source #258

Merged
merged 12 commits into from
Jan 14, 2025
Merged

[Feat][WRS-2227] Add Error/Empty state for configured data source #258

merged 12 commits into from
Jan 14, 2025

Conversation

psamusev
Copy link
Contributor

@psamusev psamusev commented Jan 10, 2025 •
edited by jira bot
Loading

This PR is focusing on adding error/empty state for configured data source

In addition, includes fixes for:

  • border color of the data source modal
  • reload data source data when linked variable value changed

Related tickets

Screenshots

@psamusev psamusev requested a review from a team as a code owner January 10, 2025 09:47
@github-actions GitHub Actions
Copy link
Contributor

PR can be checked at https://stgrafxstudiodevpublic.blob.core.windows.net/studio-ui/pr_builds/258/index.html

@github-actions GitHub Actions
Copy link
Contributor

Coverage report can be checked at https://stgrafxstudiodevpublic.blob.core.windows.net/studio-ui/coverage_reports/258/coverage.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2025 •
edited
Loading

Test Results

162 tests   160 ✅  1m 40s ⏱️
 33 suites    2 💤
  1 files      0 ❌

Results for commit 18b2dae.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

PR bundle size is 1016.304 KB and 39.741 KB more than limit.

@psamusev psamusev added the Ready for QA Defines that PR is ready for QA label Jan 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR bundle size is 1016.305 KB and 39.742 KB more than limit.

@psamusev psamusev added Ready for QA Defines that PR is ready for QA and removed Ready for QA Defines that PR is ready for QA labels Jan 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR bundle size is 1018.213 KB and 41.65 KB more than limit.

@psamusev psamusev added Ready for QA Defines that PR is ready for QA and removed Ready for QA Defines that PR is ready for QA labels Jan 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR bundle size is 1018.158 KB and 41.596 KB more than limit.

@psamusev psamusev added Ready for QA Defines that PR is ready for QA and removed Ready for QA Defines that PR is ready for QA labels Jan 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR bundle size is 1017.957 KB and 41.395 KB more than limit.

@psamusev psamusev added Ready for QA Defines that PR is ready for QA and removed Ready for QA Defines that PR is ready for QA labels Jan 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR bundle size is 1017.992 KB and 41.43 KB more than limit.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

PR bundle size is 1017.992 KB and 41.43 KB more than limit.

@github-actions GitHub Actions
Copy link
Contributor

PR bundle size is 1017.992 KB and 41.43 KB more than limit.

@psamusev psamusev added Ready for QA Defines that PR is ready for QA and removed Ready for QA Defines that PR is ready for QA labels Jan 13, 2025
@psamusev psamusev merged commit 94a72fa into main Jan 14, 2025
7 checks passed
@psamusev psamusev deleted the feature/WRS-2227-Error-Empty-state-handling-for-Data-Source branch January 14, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandraFlavia9 alexandraFlavia9 alexandraFlavia9 approved these changes

@pietervp pietervp Awaiting requested review from pietervp pietervp is a code owner automatically assigned from chili-publish/react

@brapoprod brapoprod Awaiting requested review from brapoprod brapoprod is a code owner automatically assigned from chili-publish/react

Assignees
No one assigned
Labels
Ready for QA Defines that PR is ready for QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psamusev @alexandraFlavia9