Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an
improper_ctypes
warning when bridging transparentstructs that contain non FFI safe types.
While transparent structs that contained non FFI safe types were being
passed in an FFI safe way before this commit, the Rust compiler could
not know that what we were doing was FFI safe.
This commit uses
#[allow(improper_ctypes)]
to silence the lint.Illustration
Before this commit the following bridge module:
would lead to the following warning:
This warning was a bit misleading in that it made it seem like the
RustString
needed a#[repr(C)]
annotation.The real issue was that the generated FFI representation type:
was triggering a warning because the Rust compiler can't know that the
non-FFI safe
std::string::RustString
is not being dereferenced on theSwift side.