Formal review items #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msg interface fsm doesn't unconditionally move on held last msg
mojtaba-bisheh
previously approved these changes
Jan 3, 2025
|
I'm wondering if you can assign the related issue to this PR. thanks! |
…ms' with updated timestamp and hash after successful run
…ms' with updated timestamp and hash after successful run
mojtaba-bisheh
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correcting priority on msg interface so that the last msg properly gets held by keccak.
Added busy signal to mldsa top output
Fixed skencode error signal and made it an assertion
Closes issue #64
Closes issue #46