MLDSA validation #692
Open
MLDSA validation #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojtaba-bisheh
force-pushed
the
mojtaba-abr-val
branch
from
bc507fc to
352be98
Compare
mojtaba-bisheh
requested review from
upadhyayulakiran,
calebofearth and
Nitsirks
| @@ -265,8 +266,10 @@ module caliptra_top_tb_services | |||
| // 8'h7F - Do nothing | |||
| // 8'h80: 8'h87 - Inject ECC_SEED to kv_key register | |||
| // 8'h90 - Issue PCR singing with fixed vector | |||
| // 8'h91 - Issue PCR singing with randomized vector | |||
| // 8'h92 - Check PCR singing with randomized vector | |||
| // 8'h91 - Issue PCR ECC singing with randomized vector | |||
There was a problem hiding this comment.
nit: typos in comments
There was a problem hiding this comment.
What is the purpose of this linker file?
It seems like it can be omitted, since it uses the standard offsets, and assumes the smaller 128KiB DCCM size (without failing, apparently).
If it's needed, I recommend updating it to match the other custom mldsa linkers.
| _bss_vma_end = _bss_vma_start + SIZEOF(.bss); | ||
|
|
||
| _end = _bss_lma_end; | ||
| ASSERT( _end < 0x0000C000, "ERROR: ROM size exceeds 48KiB") |
There was a problem hiding this comment.
This linker also has old ram sizes baked in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caliptra:
AdamsBridge: