Updating nightly publish website deploy-pages to v4 from v1 #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nightly is failing after updating the upload-pages-artifact step to the latest v3 from v1 (required by v1 being deprecated). The failure is due to the artifact now being named "github-pages.zip" instead of "github-pages".
I am theorizing this can be fixed by also updating the related deploy-pages action to the latest v4 version from v1. There are published examples using this same pair of versions in the same way we are attempting to use them
I cannot test this on this repo since it can only be run from main. I did run on my fork thanks to some advice from Jordan. This does appear to resolve the artifact lookup issue. There was a later failure, but I believe that is due to GitHub pages not being set up for my fork.