Update to rust 1.84 #1956
Open
Update to rust 1.84 #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurHeymans
requested review from
korran,
fdamato,
jlmahowa-amd,
mhatrevi,
jhand2,
swenson,
vsonims,
rusty1968,
bluegate010,
FerralCoder,
ajisaxena and
JohnTraverAmd
as code owners
This was referenced Feb 10, 2025
Closed
swenson
previously approved these changes
Feb 10, 2025
builder/src/lib.rs
Outdated
| @@ -193,9 +193,15 @@ pub fn build_firmware_elfs_uncached<'a>( | |||
| .arg("target.'cfg(all())'.rustflags = [\"-Dwarnings\"]"); | |||
| } | |||
|
|
|||
| // cmd.env("RUSTFLAGS", "--emit asm"); | |||
There was a problem hiding this comment.
Can we delete these parts that are commented out?
| @@ -473,3 +456,20 @@ pub fn translate_addrmap(addrmap: systemrdl::ParentScope) -> Result<Vec<Register | |||
| } | |||
| Ok(blocks) | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
There was a problem hiding this comment.
I think we can actually delete the usage of next_multiple_of now that we have the builtin method on integer types.
Newer versions of rust complain about this Signed-off-by: Arthur Heymans <[email protected]>
Newer version of rust warn about this. Signed-off-by: Arthur Heymans <[email protected]>
This fixes all the warnings and erros that the newer rust toolchain throws. 1.84 uses a bit more stack than 1.70. Signed-off-by: Arthur Heymans <[email protected]>
ArthurHeymans
force-pushed
the
rust-1.84
branch
from
5cd5f89 to
1cb6526
Compare
|
It fails formatting on DPE. Main branch of DPE seems to have that fixed, however it would require chipsalliance/caliptra-dpe#388 to be cherry-picked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for doing this is to be able to generate templates using rustcrypto which already supports ML-DSA87 (needs 1.81).
This PR fixes all the warnings and errors that the new toolchain brings.
Stack usage is increase by 4K with this newer version