Bump mill from 0.11.5 to 0.12.5 #133
Merged
+19
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs Since Mill 0.12 requires Java 11+, this also needs to update the README to no longer suggest Java 8 (possibly with a comment clarifying that Chisel works with Java 8 but our preferred build tool, Mill, requires Java 11). |
* Add .mill-jvm-opts * Add explanation comments in build.mill Signed-off-by: Qiming Chu <[email protected]>
Update README to clarify that Mill 0.12+ requires Java 11 or newer, while noting that Chisel itself is compatible with Java 8. Signed-off-by: Qiming Chu <[email protected]>
|
Sorry, I missed changing build.sc to build.mill in test.yml. Could we re-run the CI? |
|
You might want to switch from using |
Signed-off-by: Qiming Chu <[email protected]>
jackkoenig
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.mill-versionfile to specify the new mill version 0.12.5.build.millfile tobuild.scto match the updated mill version.SbtModuleandSbtModuleTestsimports to reflect the changes in the mill 0.12.5 API.