Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dataview to explanations.md #2167

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Conversation

Burnleydev1
Copy link
Contributor

@Burnleydev1 Burnleydev1 commented Oct 11, 2021

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

Documentation

API Impact

No impact

Backend Code Generation Impact

No

Desired Merge Strategy

Squash

Release Notes

Added dataview to explanation.md

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.3.x, [small] API extension: 3.4.x, API modification or big change: 3.5.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@mwachs5 mwachs5 modified the milestones: 3.5.0, 3.4.x Oct 11, 2021
@mwachs5 mwachs5 added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Oct 11, 2021
@mergify mergify bot merged commit 0556c61 into chipsalliance:master Oct 11, 2021
@Burnleydev1
Copy link
Contributor Author

Hello @mwachs5 this issue is still not solved, dataview explanation is still absent.

@mwachs5
Copy link
Contributor

mwachs5 commented Oct 12, 2021

You mean absent on the web? That is because DataView is a 3.5.0 feature, we have not released 3.5.0 yet. The website docs are pointing to the 3.4.x branch, once we officially release 3.5.0 we will update the website pointer to pull from the 3.5.x branch.

@Burnleydev1
Copy link
Contributor Author

Oh okay I understand you.

@jackkoenig
Copy link
Contributor

It'd be great if we could host multiple versions at a time on the website (and I've filed tracking issue: freechipsproject/www.chisel-lang.org#203), but this is quite a bit of work to support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants