[GSOC] integrated support for Zvbc and Zvkg instructions #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksco
requested changes
Aug 17, 2024
generator/insn_util.go
Outdated
| @@ -87,6 +87,10 @@ func (v VLEN) Valid() bool { | |||
| return 64 <= v && v <= 4096 && v&(v-1) == 0 | |||
| } | |||
|
|
|||
| func (v VLEN) Zvkg_validVLEN() bool{ | |||
| return v == 128 | |||
There was a problem hiding this comment.
Are you sure about this? The spec says "All of these instructions work on 128-bit element groups comprised of four 32-bit elements." .. which I don't think this means these instructions are only valid when vlen is 128.
There was a problem hiding this comment.
Any VLEN * LMUL >=128 should be okay.
There was a problem hiding this comment.
Sorry I misunderstood, you're right Element Group width should be 128 not the vlen
[GSOC] removed wrong valid vlen constraint for Zvkg [GSOC] fixed
SyedHassanUlHaq
changed the title
ksco
reviewed
Aug 19, 2024
generator/insn_util.go
Outdated
| @@ -83,6 +83,10 @@ func (l LMUL) String() string { | |||
|
|
|||
| type VLEN int | |||
|
|
|||
| func (v VLEN) Zvkg_validVLEN() bool{ | |||
| return 128 <= v && v <= 4096 && v&(v-1) == 0 | |||
There was a problem hiding this comment.
There is no limit on the VLEN, as long as VLEN * LMUL >= 128, it's okay.
|
Thank you, it looks good now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.