-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add license header to top of all code files #762
Add license header to top of all code files #762
Conversation
847857a
to
afe935d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bunch of comments.
Please go through the checklist at f4pga/ideas#47 and confirm that everything in it has been done for this CL, then rerequest review.
A copy from the original task to track progress here:
|
afe935d
to
32a6fe9
Compare
@mithro thanks for your comments. The only thing that is missing from the list in f4pga/ideas#47 is the CI to check for all of this. I guess this should be something common for all the repositories. Do we have something like that somewhere already? |
@tgorochowik, @acomodi added a script for checking this in this PR chipsalliance/fpga-tool-perf#64 |
79256fd
to
41cae9e
Compare
41cae9e
to
ebf306f
Compare
What is the status of this one ? It requires rebasing, but other than that, is @mithro happy ? |
ebf306f
to
9371d61
Compare
Rebased the changes onto current master. All the requirements are met so I think this is ready (assuming the CI succeeds). |
@tgorochowik -- Can you rebase this and we can merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase this and update the scripts from the copies in python-symbiflow-v2x - then please ping me and I'll merge it.
9371d61
to
7c33065
Compare
Fixes #749 Signed-off-by: Tomasz Gorochowik <[email protected]>
Signed-off-by: Tomasz Gorochowik <[email protected]>
Signed-off-by: Tomasz Gorochowik <[email protected]>
List organizations + individual contributors with 5 or more commits. If more contributors want to be listed we can of course do that. Signed-off-by: Tomasz Gorochowik <[email protected]>
Signed-off-by: Tomasz Gorochowik <[email protected]>
Signed-off-by: Tomasz Gorochowik <[email protected]>
Signed-off-by: Tomasz Gorochowik <[email protected]>
Signed-off-by: Tomasz Gorochowik <[email protected]>
Origin: https://github.com/billswartz7/utd-SystemVerilog/blob/03cec19f565ee3750af8173d5b89b00465a8e66c/LICENSE.txt Signed-off-by: Tomasz Gorochowik <[email protected]>
Imported from: https://github.com/SymbiFlow/fpga-tool-perf/blob/f8d143b73f670eea5efdbe96f1236d82998c896e/.github/travis/check_license.sh Fixes: #773 Co-authored-by: Alessandro Comodi <[email protected]> Signed-off-by: Tomasz Gorochowik <[email protected]>
Source: https://github.com/SymbiFlow/python-symbiflow-v2x/blob/d9f8659bcf46afe4b11f324fb1476c156b0b1c09/.github/ci/check_license.sh Signed-off-by: Tomasz Gorochowik <[email protected]>
Signed-off-by: Tomasz Gorochowik <[email protected]>
Signed-off-by: Tomasz Gorochowik <[email protected]>
Signed-off-by: Tomasz Gorochowik <[email protected]>
b4875fc
to
74bdd81
Compare
Signed-off-by: Tomasz Gorochowik <[email protected]>
Signed-off-by: Tomasz Gorochowik <[email protected]>
One minor fix;
|
Signed-off-by: Tomasz Gorochowik <[email protected]>
Signed-off-by: Tomasz Gorochowik <[email protected]>
Fixes #749