Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license header to top of all code files #762

Merged
merged 18 commits into from
Dec 23, 2020

Conversation

tgorochowik
Copy link
Member

Fixes #749

@tgorochowik tgorochowik requested a review from mithro April 21, 2020 12:35
@tgorochowik tgorochowik force-pushed the add-license-headers branch from 847857a to afe935d Compare April 21, 2020 13:52
Copy link
Collaborator

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunch of comments.

Please go through the checklist at f4pga/ideas#47 and confirm that everything in it has been done for this CL, then rerequest review.

Makefile Show resolved Hide resolved
generators/ariane Outdated Show resolved Hide resolved
generators/ariane Show resolved Hide resolved
generators/ariane Show resolved Hide resolved
tools/BaseRunner.py Outdated Show resolved Hide resolved
@tgorochowik
Copy link
Member Author

tgorochowik commented Apr 22, 2020

A copy from the original task to track progress here:

  • COPYING file renamed to LICENSE file
  • The LICENSE file should start with - Copyright 20XX The [Project Name] Authors. -- See https://opensource.google/docs/releasing/authors/
  • Add or update the AUTHORS files to have the text as shown at https://opensource.google/docs/releasing/authors/
  • Remove the un-needed All rights reserved. text.
  • Make sure all code files have the license specifier at the top of the file as shown at https://opensource.google/docs/releasing/licenses/
  • All code files should have SPDX identifiers.
  • Add CI which checks for all this.
  • Make sure that all third_party code is under third_party directory.
  • Make sure that all third_party directories have a correct LICENSE file.
  • Python files should have a #!/usr/bin/env python3 as the shebang line.
  • Python files should have a # coding: utf-8 as the second line after the shebang.

@tgorochowik tgorochowik force-pushed the add-license-headers branch from afe935d to 32a6fe9 Compare April 22, 2020 10:20
@tgorochowik tgorochowik requested a review from mithro April 22, 2020 10:23
@tgorochowik
Copy link
Member Author

@mithro thanks for your comments.

The only thing that is missing from the list in f4pga/ideas#47 is the CI to check for all of this. I guess this should be something common for all the repositories. Do we have something like that somewhere already?

@kgugala
Copy link
Member

kgugala commented Apr 22, 2020

@mithro thanks for your comments.

The only thing that is missing from the list in SymbiFlow/ideas#47 is the CI to check for all of this. I guess this should be something common for all the repositories. Do we have something like that somewhere already?

@tgorochowik, @acomodi added a script for checking this in this PR chipsalliance/fpga-tool-perf#64

@tgorochowik tgorochowik force-pushed the add-license-headers branch 2 times, most recently from 79256fd to 41cae9e Compare May 7, 2020 12:25
@tgorochowik
Copy link
Member Author

Added the license checker by @acomodi from #773

@tgorochowik tgorochowik force-pushed the add-license-headers branch from 41cae9e to ebf306f Compare May 14, 2020 08:18
@hzeller
Copy link
Collaborator

hzeller commented Jul 8, 2020

What is the status of this one ? It requires rebasing, but other than that, is @mithro happy ?

@tgorochowik tgorochowik force-pushed the add-license-headers branch from ebf306f to 9371d61 Compare July 24, 2020 07:37
@tgorochowik
Copy link
Member Author

Rebased the changes onto current master. All the requirements are met so I think this is ready (assuming the CI succeeds).

@mithro
Copy link
Collaborator

mithro commented Dec 2, 2020

@tgorochowik -- Can you rebase this and we can merge it?

Copy link
Collaborator

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this and update the scripts from the copies in python-symbiflow-v2x - then please ping me and I'll merge it.

.github/travis/check_license.sh Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
AUTHORS Show resolved Hide resolved
tgorochowik and others added 12 commits December 3, 2020 16:10
Fixes #749

Signed-off-by: Tomasz Gorochowik <[email protected]>
Signed-off-by: Tomasz Gorochowik <[email protected]>
Signed-off-by: Tomasz Gorochowik <[email protected]>
List organizations + individual contributors with 5 or more commits. If
more contributors want to be listed we can of course do that.

Signed-off-by: Tomasz Gorochowik <[email protected]>
Signed-off-by: Tomasz Gorochowik <[email protected]>
Signed-off-by: Tomasz Gorochowik <[email protected]>
Signed-off-by: Tomasz Gorochowik <[email protected]>
@mithro
Copy link
Collaborator

mithro commented Dec 3, 2020

One minor fix;

ERROR: third_party/cores/black-parrot does not have the LICENSE file.
ERROR: third_party/tests/axi_vip does not have the LICENSE file.
Error: Process completed with exit code 1.

Signed-off-by: Tomasz Gorochowik <[email protected]>
Signed-off-by: Tomasz Gorochowik <[email protected]>
@tgorochowik tgorochowik merged commit 28af35a into chipsalliance:master Dec 23, 2020
@tgorochowik tgorochowik deleted the add-license-headers branch December 23, 2020 12:01
@mithro mithro linked an issue Apr 11, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add license automated check in Travis Add license header to top of all code files
4 participants