-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix sarift-fmt checks for test/basic.sh
Previously, they were passing non-sarif input to sarif-fmt, which obviously resulted in errors. /facepalm Signed-off-by: Adam Cmiel <[email protected]>
- Loading branch information
Showing
4 changed files
with
46 additions
and
4 deletions.
There are no files selected for viewing
8 changes: 7 additions & 1 deletion
8
test/resources/files-to-check/busybox-sh.yaml-outputs/sarif-fmt.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,7 @@ | ||
Error: missing field `runs` at line 36 column 1 | ||
warning: Double quote to prevent globbing and word splitting. | ||
┌─ test/resources/files-to-check/busybox-sh.yaml:4:8 | ||
│ | ||
4 │ echo $HELLO_THERE | ||
│ ^^^^^^^^^^^^ | ||
|
||
warning: 1 warnings emitted |
8 changes: 7 additions & 1 deletion
8
test/resources/files-to-check/nested-scripts.yaml-outputs/sarif-fmt.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,7 @@ | ||
Error: missing field `runs` at line 15 column 1 | ||
warning: Remove surrounding $() to avoid executing output (or use eval if intentional). | ||
┌─ test/resources/files-to-check/nested-scripts.yaml:9:3 | ||
│ | ||
9 │ $(bash script.sh) | ||
│ ^^^^^^^^^^^^^^^^^ | ||
|
||
warning: 1 warnings emitted |
21 changes: 20 additions & 1 deletion
21
test/resources/files-to-check/tektontask.yaml-outputs/sarif-fmt.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,20 @@ | ||
Error: missing field `runs` at line 58 column 1 | ||
error: On most OS, shebangs can only specify a single parameter. | ||
┌─ test/resources/files-to-check/tektontask.yaml:34:9 | ||
│ | ||
34 │ #!/bin/bash -e -u -o pipefail | ||
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
warning: Double quote to prevent globbing and word splitting. | ||
┌─ test/resources/files-to-check/tektontask.yaml:29:14 | ||
│ | ||
29 │ eval $SCRIPT | ||
│ ^^^^^^^ | ||
|
||
warning: watery_tart is referenced but not assigned. | ||
┌─ test/resources/files-to-check/tektontask.yaml:27:86 | ||
│ | ||
27 │ echo "You can't expect to wield supreme executive power just 'cause some $watery_tart threw a sword at you!" | ||
│ ^^^^^^^^^^^^ | ||
|
||
warning: 2 warnings emitted | ||
error: 1 errors emitted |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters