Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set a proxy to use for the request #195

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: set a proxy to use for the request #195

wants to merge 2 commits into from

Conversation

aalcaidep
Copy link

@aalcaidep aalcaidep commented Oct 29, 2020 •
edited by aik099
Loading

Closes #194.

aik099
aik099 reviewed Oct 29, 2020
View reviewed changes
Copy link
Collaborator

@aik099 aik099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, that you're specifying proxy per API-call. Please specify a use case for such implementation.

If you don't mind, then please change implementation to allow specifying proxy upon CurlClient construction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aik099 aik099 aik099 left review comments

Assignees
No one assigned
Labels
state-pending-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow set proxy to use
2 participants
@aalcaidep @aik099