Adding sensor to proper dag #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! thaaanks! |
claudiazi
approved these changes
Jul 17, 2023
vlad-choco
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: DATA=1500
Sensor was not giving slack alert when failed.
Root Cause: When sensor operator was created the dag object was not passed into the operator as a parameter, hence the default arguments (which contains what to do on failure) were also not passed into the sensor operator.
This fix is adding the dag object into the sensor operator on creation time, making sure that all default arguments, like the on_failure_callback function is also passed in.
tested in tst environment