Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/data 1791 defferable sensors #33

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Feature/data 1791 defferable sensors #33

merged 4 commits into from
Apr 15, 2024

Conversation

siklosid
Copy link
Member

@siklosid siklosid commented Apr 15, 2024 •
edited by jira bot
Loading

DATA-1791

Enabling deferrable sensors:

  1. Upgrading dev env to python 3.9 and airflow to 2.9.0
  2. In airflow 2.9.0 making a sensor deferrable is an argument of the sensor itself. In this commit instead of using hardwired mapping of default arguments of the sensor, we make it more flexible and a general external_sensor_default_args is put in dagger config file which can freely set any sensor parameters available.

@siklosid siklosid requested a review from a team as a code owner April 15, 2024 09:04
@swarmia Swarmia
Copy link

swarmia bot commented Apr 15, 2024

✅  Linked to Task DATA-1791 · Remove bottlenecks from Airflow using deferrable sensors

kiranvasudev
kiranvasudev previously approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@kiranvasudev kiranvasudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏽

ci is failing though

@siklosid siklosid merged commit 7b9bd16 into master Apr 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranvasudev kiranvasudev kiranvasudev approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siklosid @kiranvasudev