Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#51) Remove hard coded entry for starts with #52

Conversation

AdmiringWorm
Copy link
Member

Description Of Changes

This updates the format that is being used when we try to search for an
id that starts with something.

This is done by updating the format to not use a hard coded instance of
chocolatey.

Motivation and Context

By having a hard coded value, we are not able to properly search for an id that starts with something.

Testing

  1. Pull in the changes to your local choco repository using the update-nuget-client.ps1 script.
  2. Attempt to search for a package using the argument for id starting with (example: choco search sysinternals --id-starts-with).
  3. Verify the expected results are returned.

Operating Systems Testing

  • Windows 10

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #51

This updates the format that is being used when we try to search for an
id that starts with something.

This is done by updating the format to not use a hard coded instance of
`chocolatey`.
@AdmiringWorm AdmiringWorm self-assigned this Feb 26, 2025
@AdmiringWorm AdmiringWorm requested a review from gep13 February 26, 2025 11:08
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit b6e433b into chocolatey:develop Feb 26, 2025
1 check passed
@gep13
Copy link
Member

gep13 commented Feb 26, 2025

@AdmiringWorm I have just taken this for a spin, and it works exactly as expected. Thanks for getting this fixed, and apologies again for introducing the problem in the first place!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardcoded entry in the IdStartsWithFormat string
2 participants