Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#250) Removes 'Choco' Alias from Invoke-Choco #273

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

JPRuskin
Copy link
Member

Description Of Changes

Removes the alias from Invoke-Choco.

Motivation and Context

The alias remaining in the session after the installation could confuse users.

Testing

  • Tested deploying to 2022 manually
  • Automated testing

Operating Systems Testing

  • Windows 2019
  • Windows 2022

Change Types Made

  • [ ] Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • [ ] Breaking change (fix or feature that could cause existing functionality to change).
  • [ ] Documentation changes.
  • PowerShell code changes.

Change Checklist

  • [ ] Requires a change to the documentation.
  • [ ] Documentation has been updated.
  • [ ] Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • [ ] PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

Fixes #

@JPRuskin JPRuskin force-pushed the chocoAlias branch 3 times, most recently from ea1a0e1 to b0887a1 Compare September 27, 2024 12:07
Copy link

github-actions bot commented Sep 27, 2024

C4bVerification-Win2022AzureEditionCore-self-signed

103 tests   103 ✅  15s ⏱️
 14 suites    0 💤
  4 files      0 ❌

Results for commit 3f517f1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 27, 2024

C4bVerification-Win2022AzureEditionCore-single

103 tests   103 ✅  14s ⏱️
 14 suites    0 💤
  4 files      0 ❌

Results for commit 3f517f1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 27, 2024

C4bVerification-Win2019Datacenter-self-signed

103 tests   103 ✅  21s ⏱️
 14 suites    0 💤
  4 files      0 ❌

Results for commit 2a1af36.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 27, 2024

C4bVerification-Win2019Datacenter-single

103 tests   103 ✅  30s ⏱️
 14 suites    0 💤
  4 files      0 ❌

Results for commit 3f517f1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 27, 2024

C4bVerification-Win2019Datacenter-wildcard

103 tests   103 ✅  23s ⏱️
 14 suites    0 💤
  4 files      0 ❌

Results for commit 2a1af36.

♻️ This comment has been updated with latest results.

This is good practice for work going forward, and begins to enable some of the later stage work we want to do to unify our environment setup(s).

sq
Removes the alias of "choco", which causes a lot of replacements.

This is in order to not confuse users, after running the QSG scripts, who don't expect choco to be replaced.
@steviecoaster steviecoaster merged commit 2f1cf3b into main Oct 3, 2024
15 checks passed
@steviecoaster steviecoaster deleted the chocoAlias branch October 3, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants