Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#261) Remove LocalChocolateySetup Source #276

Merged
merged 4 commits into from
Oct 15, 2024
Merged

(#261) Remove LocalChocolateySetup Source #276

merged 4 commits into from
Oct 15, 2024

Conversation

ryanrichter94
Copy link
Member

@ryanrichter94 ryanrichter94 commented Oct 1, 2024

Description Of Changes

  • Remove the LocalChocolateySetup source from the server
  • Add Chocolatey Sources Testing section to allow further source testing in the future.
  • Add a test to check if the LocalChocolateySetup source is removed
  • Add a test to check if the ChocolateyInternal source exists
  • Add Pester package to manifest
  • Source all package installs past Nexus Setup from the Nexus repository.

Motivation and Context

Remove a source that is no longer needed after all packages have been pushed to the repo and all steps have run the source packages.

Add tests for changes made.

Testing

  1. Local VM testing
  2. Automated testing

Operating Systems Testing

  • Windows Server 2019
  • Windows Server 2022

Change Types Made

  • [ ] Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • [ ] Breaking change (fix or feature that could cause existing functionality to change).
  • [ ] Documentation changes.
  • PowerShell code changes.

Change Checklist

  • [ ] Requires a change to the documentation.
  • [ ] Documentation has been updated.
  • Tests to cover my changes have been added.
  • All new and existing tests passed?

Related Issue

Fixes #261

@ryanrichter94 ryanrichter94 self-assigned this Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

C4bVerification-Win2022AzureEditionCore-wildcard

105 tests   105 ✅  15s ⏱️
 15 suites    0 💤
  4 files      0 ❌

Results for commit a6934b5.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 1, 2024

C4bVerification-Win2022AzureEditionCore-self-signed

105 tests   105 ✅  15s ⏱️
 15 suites    0 💤
  4 files      0 ❌

Results for commit a6934b5.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 1, 2024

C4bVerification-Win2019Datacenter-self-signed

105 tests   105 ✅  24s ⏱️
 15 suites    0 💤
  4 files      0 ❌

Results for commit a6934b5.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 1, 2024

C4bVerification-Win2022AzureEditionCore-single

105 tests   105 ✅  15s ⏱️
 15 suites    0 💤
  4 files      0 ❌

Results for commit a6934b5.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 1, 2024

C4bVerification-Win2019Datacenter-wildcard

105 tests   105 ✅  22s ⏱️
 15 suites    0 💤
  4 files      0 ❌

Results for commit a6934b5.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 1, 2024

C4bVerification-Win2019Datacenter-single

105 tests   105 ✅  23s ⏱️
 15 suites    0 💤
  4 files      0 ❌

Results for commit a6934b5.

♻️ This comment has been updated with latest results.

@ryanrichter94 ryanrichter94 force-pushed the QSG-261 branch 2 times, most recently from ea25d8d to a41b27f Compare October 7, 2024 13:58
@ryanrichter94 ryanrichter94 force-pushed the QSG-261 branch 3 times, most recently from 649b209 to a6934b5 Compare October 10, 2024 18:49
- Remove LocalChocolateySetup source from server
- Add Chocolatey Sources Testing
- Add test to check if the LocalChocolateySetup source is removed
- Add test to check if the ChocolateyInternal source exists
Manually append sourcing packages from ChocolateyInternal past Nexus Setup
Copy link
Member

@JPRuskin JPRuskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still unsure about undoing my change to the sourcing, but all good.

@JPRuskin JPRuskin merged commit c446da8 into main Oct 15, 2024
15 checks passed
@JPRuskin JPRuskin deleted the QSG-261 branch October 15, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove LocalChocolateySetup Source Once Guide Finishes
2 participants