Update Most Builds to VL+PLMC #364
Conversation
bcaddy
force-pushed
the
dev-plmcvlDefault
branch
from
a640a76 to
706e93b
Compare
Updated the default hydro build to use the Van Leer (VL) and PLMC build options. Also, updated the test data for those new builds
Also updated test data
Updated template, basic_scalar, disk, dust, rot_proj, static_grav to use PLMC and Van Leer integrator
Avoids issues with running clang-tidy in non-VL builds
bcaddy
force-pushed
the
dev-plmcvlDefault
branch
from
5fbc2da to
f240b3b
Compare
|
Just to double-check -- were you able to confirm that the spherical collapse test is actually collapsing now? It was working when I initially added the system test, but when @evazlimen documented it last August it was not. |
|
I compared slices of the old and new fiducial data and there were qualitatively very similar; ie a big dot in the middle. I thought the old fiducial data was definitely correct but I’m not totally sure. |
|
Sounds good. If you could add a plot of the new slice data to the documented examples page, that would be great (ultimately we will need to do this for all the examples, but that's a longer-term project). |
|
Sure. I assume you want a higher resulting plot like 128^3 or 256^3 rather than the low res test version? |
|
Yes, I think specifically the plot that results from using the example parameter file (which is 256^3). |
Summary
Updated all builds, except cosmology, to use the Van Leer (VL) integrator and Piecewise Linear Method in the Characteristic variables (PLMC) reconstruction.
I'd like @helenarichie and @ojwg to take a look to make sure I'm not breaking any of their builds.