WIP: feedback overhaul #386
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the treatment Temperature floor in CIE case.
Specifically, this commit converted the stellar-wind initializer so that it now uses the new parsing functions. Note, that I wasn't anywhere near as careful as I was while converting the supernova initializer. I literally just made sure the converted code compiled. For context, when I converted the supernova initializer, I took care to ensure that the results were bitwise identical.
…alues and it now makes use of DeviceVector.
While everything compiles just fine, I wasn't as careful as I was when factoring out the SNRateCalc class. For context, when I factored out the SNRateCalc class, I took care to ensure that there were no alterations to any of the outputs. In contrast, for the SWRateCalc class I didn't actually check any runs that employ stellar winds (although they definitely do compile correctly).
constructors for SNRateCalc and SWRateCalc.
…ly the scope kept creeping in this commit.
…olidated with Cluster_Feedback_Kernel
…unused arguments.
The dual-energy formalism now respects crashed cells in the function call `Select_Internal_Energy_ND` -> the function does not modify any cells where the cell "crashed" -> while considering the neighboring values of the crashed cells, we ignore any neighbors that "crashed" -> we also now explicitly pick advected internal energy over the internal energy computed from total energy in cases where the total energy is positive, but does not exceed kinetic energy. This was all done in preparation for Averaging Crashed Cells after
It now operates after the dual-energy formalism.
mabruzzo
force-pushed
the
s99_f-feedback
branch
from
269ad61 to
bed1fce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is eventually going to be a full-fledged PR for merging in the new stellar feedback. But it's not currently prepared for review....
At the moment, I just merged changes from
maininto this branch. I'm just being a little lazy. I recently mergedmaininto this branch and I want to execute the test suite