Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CZ-536] detail qa #111

Merged
merged 4 commits into from
Jul 28, 2023
Merged

[CZ-536] detail qa #111

merged 4 commits into from
Jul 28, 2023

Conversation

leejiho9898
Copy link
Member

@leejiho9898 leejiho9898 commented Jul 22, 2023

πŸ“‘ μž‘μ—…λ¦¬μŠ€νŠΈ

  • μ’‹μ•„μš” μ‹«μ–΄μš” ν΄λ¦­μ‹œ μΈν„°λ ‰μ…˜ μ„€μ •
  • νˆ¬ν‘œ λ””ν…ŒμΌ νŽ˜μ΄μ§€μ— 글쓴이 μΆ”κ°€
  • νˆ¬ν‘œ 전체 톡계바에 A, B 글씨 μΆ”κ°€

πŸ“˜ λ¦¬λ·°λ…ΈνŠΈ

  • λŒ€λŒ“κΈ€ μž‘μ—…ν›„ open μ˜ˆμ •

@vercel
Copy link

vercel bot commented Jul 22, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
client-web βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 28, 2023 3:43pm

@leejiho9898 leejiho9898 requested a review from Leejha July 22, 2023 18:27
@leejiho9898 leejiho9898 marked this pull request as draft July 22, 2023 18:28
Copy link
Member

@Leejha Leejha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€

export { default as LightAString } from "./Light-A.png";
export { default as DarkAString } from "./Dark-A.png";
export { default as LightBString } from "./Light-B.png";
export { default as DarkBString } from "./Dark-B.png";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5: svg둜 λ„£λŠ”κ²Œ μ’‹μ•˜μ„ 것 κ°™λ‹€λŠ” 생각이 λ“œλ„€μš”!

Copy link
Member Author

@leejiho9898 leejiho9898 Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

쒋은 의견인거 κ°™μ•„μš” κ°μ‚¬ν•©λ‹ˆλ‹€

<TagBox>
{userGender}
<DivideTag /> {userAge}
<DivideTag /> {userMbti}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5: 곡톡 μ»΄ν¬λ„ŒνŠΈμ— DivideLine이라고 μžˆλŠ”λ° κ·Έκ±° μ‚¬μš©μ€ νž˜λ“€κΉŒμš”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν•΄λ³΄λ‹ˆ DivideLineκ³Ό μ»¬λŸ¬κ°€ λ‹¬λΌμ„œ κ·Έλƒ₯ μ‚¬μš©ν•˜κΈ°λŠ” νž˜λ“€κ³  μ • μž¬ν™œμš©μ„ ν•˜λ €λ©΄
DivideLineμ—μ„œ 컬러λ₯Ό λ³€κ²½ν•  수 μžˆλ„λ‘ μˆ˜μ •ν•˜λŠ” λ°©λ²•λ°–μ—λŠ” 없을거 κ°™μ•„μš”
그런데 리뉴얼 μ§μ „μž„μ„ κ³ λ €ν•˜λ©΄ κ³Όνˆ¬μžκ°€ μ•„λ‹κΉŒ ν•˜λŠ” 생각이 λ“€κΈ΄ν•©λ‹ˆλ‹€

};
}

const VoteWriterBox = ({ writer }: Props) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p4: μ‚¬μ†Œν•œκ±°κΈ΄ν•œλ° μ»¨λ²€μ…˜λŒ€λ‘œ ν™”μ‚΄ν‘œ ν•¨μˆ˜λŒ€μ‹  function으둜 μ‚¬μš©ν•˜λŠ”κ±΄ μ–΄λ–¨κΉŒμš”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•„ μ»¨λ²€μ…˜μ„ μ •ν•΄λ†¨μ—ˆκ΅°μš” μˆ˜μ •ν•˜κ² μŠ΄λ‹ˆλ‹€

@leejiho9898 leejiho9898 marked this pull request as ready for review July 28, 2023 15:41
@github-actions github-actions bot requested a review from Leejha July 28, 2023 15:42
@leejiho9898 leejiho9898 merged commit ad943f1 into develop Jul 28, 2023
1 check passed
@Leejha Leejha deleted the CZ-536_detail_qa branch July 28, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants