[JR-567] 주루마블 초기 세팅 #115
Merged
[JR-567] 주루마블 초기 세팅 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leejiho9898
approved these changes
Aug 5, 2023
Comment on lines
-11
to
-13
| "paths": { | ||
| "@src/*": ["src/*"] | ||
| }, |
There was a problem hiding this comment.
절대경로를 제거하신 이유가 주루마블에서 web 경로로 import가 되어서 인가요?
There was a problem hiding this comment.
절대경로는 paths가 아니라 baseUrl에서 설정해주긴 했는데 paths도 따로 또 설정해주면 좋을 것 같긴 해요
There was a problem hiding this comment.
흠 결론적으로 제거하신 이유가 위 사항 때문은 아니고 다른 이유가 있다는 말씀이시죠?
Comment on lines
+12
to
+27
| "@types/eslint": "^8", | ||
| "@types/node": "18.11.17", | ||
| "@types/react": "^18.2.18", | ||
| "@types/react-dom": "^18.2.7", | ||
| "@typescript-eslint/eslint-plugin": "^6.2.1", | ||
| "@typescript-eslint/parser": "^6.2.1", | ||
| "eslint": "^8.46.0", | ||
| "eslint-config-prettier": "^8.10.0", | ||
| "eslint-import-resolver-typescript": "^3.5.5", | ||
| "eslint-plugin-import": "^2.28.0", | ||
| "eslint-plugin-jsx-a11y": "^6.7.1", | ||
| "eslint-plugin-prettier": "^5.0.0", | ||
| "eslint-plugin-react": "^7.33.1", | ||
| "eslint-plugin-react-hooks": "^4.6.0", | ||
| "prettier": "^2.8.1", | ||
| "typescript": "^4.9.3" | ||
| "typescript": "4.9.3" |
There was a problem hiding this comment.
이렇게 린트를 루트에 설정하면 모든 레포에 동일한 eslint가 적용 되는건가요?
There was a problem hiding this comment.
이론상 그래야합니다. 그런데 적용이 잘 된건지는 모르겠네요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 작업리스트
📘 리뷰노트