[JR-733] 투표 상세페이지 api 적용 #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Leejha
approved these changes
Sep 17, 2023
| }); | ||
|
|
||
| return { mutateBookMark, bookMarkCheckQuery }; | ||
| } |
There was a problem hiding this comment.
p5: 이거 검색 페이지에서도 사용하고 있는데 따로 수정할 필요 없죠??
| mbti, | ||
| nickName, | ||
| userId, | ||
| }, |
There was a problem hiding this comment.
p5: 개인적으로 너무 길어지면 const {~} 로 빼는 것이 보기 편하더라고요
그런데 이거 객체 분할 하고 그대로 다시 넣고 있는데 쪼갤 필요가 있나요??
There was a problem hiding this comment.
commentList에서 쓸거만 꺼내서 보내주고 있는데
Comment 에서 안쓰이는 데이터까지 넘기는거보단 필요한 데이터만 추출해서 넣는게 좋을거 같아서요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 작업리스트
📘 리뷰노트