Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JR-898] 전통주 이미지가 로드되지 않는 이슈 해결 #219

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

Leejha
Copy link
Member

@Leejha Leejha commented Mar 22, 2024

📑 작업리스트

image
  • 외부 전통주 이미지의 접근 제한 이슈로 img 태그의 유효하지 않은 src 값 발생
  • alt에 입력한 텍스트가 그대로 표시됨
  • image 태그의 onError 속성을 이용하여 이미지 로드 실패시 fallback image를 보여주는 컴포넌트 구현
  • 전통주 이미지를 사용하는 컴포넌트에 FallbackImage가 적용된 DrinkImageWrapper 적용
image

📘 리뷰노트

Copy link

vercel bot commented Mar 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jurumarble ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 10:51am

@Leejha Leejha force-pushed the JR-898-fix-fail-to-load-image branch from fe86932 to 6016add Compare March 22, 2024 10:47
@Leejha Leejha merged commit 42db088 into develop Mar 22, 2024
3 checks passed
@Leejha Leejha deleted the JR-898-fix-fail-to-load-image branch March 22, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant