Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Stop adding baseline standards valid on cert date #1774

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

kekey1
Copy link
Contributor

@kekey1 kekey1 commented Jan 10, 2025

Many of the standards that were valid as of certification date are no longer applicable. They should not be added to any listing.

[#OCD-4793]

Many of the standards that were valid as of certification date are no
longer applicable. They should not be added to any listing.

[#OCD-4793]
@kekey1 kekey1 requested a review from tmy1313 as a code owner January 10, 2025 18:34
@kekey1 kekey1 requested a review from andlar January 10, 2025 18:34
tmy1313
tmy1313 previously approved these changes Jan 13, 2025
andlar
andlar previously approved these changes Jan 13, 2025
After switching to upload-to-update, the CSV empty fields were being
parsed as empty strings rather than nulls. This commit adds code that
sets all user-settable string fields (I hope) to null if they are empty.

[#OCD-4793]
@kekey1 kekey1 dismissed stale reviews from andlar and tmy1313 via 79bbfa0 January 16, 2025 18:46
@kekey1 kekey1 merged commit dee649e into chpladmin:staging Jan 17, 2025
1 check passed
@kekey1 kekey1 deleted the OCD-4793 branch January 17, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants