OCD-3928: Move surveillance endpoints under certified-products controller #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kekey1
commented
Jan 15, 2025
kekey1
commented
- Also get rid of certifiedProduct field usage in Surveillance object and deprecate that field
- Get rid of the long-deprecated /collections/certified-products endpoint. The surveillance page was the only place remaining using this endpoint.
The surveillance PUT, POST, and DELETE endpoints are being moved to the certified product controller. The new endpoint will have the format /certified-products/<id>/surveillance/<id>. Since the certified product ID will be part of the URL path, it does not need to be included as part of the Surveillance object. That design was always a little weird. This commit also removes use of the certifiedProduct field as much as possible. [#OCD-3928]
[#OCD-3928]
Breaking Change Hallelujah!! [#OCD-3928]
andlar
previously approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.