Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove redundant owner and repo check, that adds useless entry, fixes #71 #73

Conversation

stevenxxiu
Copy link
Contributor

This useless entry https://github.com/foo/bar sometimes shows up for me, but I forgot how.

Looking at the code, it seems to have no purpose. The check here is repeated later on.

@sportshead
Copy link
Contributor

This check is needed to prefill the URL for the find and replace in line 54. Removing it will break any links that don't have a full URL.

@stevenxxiu
Copy link
Contributor Author

@sportshead Ah thanks. Do you have a test case where I can trigger this condition? I forgot how I triggered it last, but it annoys me often enough.

@sportshead
Copy link
Contributor

Folder without a git repo/no remotes, put a comment like See chrishrb/gx.nvim#73 should do it

@stevenxxiu stevenxxiu closed this Nov 30, 2024
@stevenxxiu stevenxxiu deleted the fix/remove-redundant-owner-repo-check branch November 30, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants