Merge pull request #19 from chriskonnertz/mb_substr

Multibyte Support (Description)
chriskonnertz · Mar 29, 2016 · 577875d · 577875d
2 parents 98d240c + bf2e8c4
commit 577875d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 5 deletions.
diff --git a/src/ChrisKonnertz/OpenGraph/OpenGraph.php b/src/ChrisKonnertz/OpenGraph/OpenGraph.php
@@ -11,7 +11,7 @@ class OpenGraph {
     /**
      * The version number
      */
-    const VERSION = '1.0.0';
+    const VERSION = '1.0.2';
 
     /**
      * The name prefix
@@ -301,11 +301,11 @@ public function description($description, $maxLength = 250)
         $description = trim(strip_tags($description));
         $description = preg_replace("/\r|\n/", '', $description);
 
-        $length = strlen($description);
+        $length = mb_strlen($description);
 
-        $description = substr($description, 0, $maxLength);
+        $description = mb_substr($description, 0, $maxLength);
 
-        if (strlen($description) < $length) {
+        if (mb_strlen($description) < $length) {
             $description .= '...';
         }
 

diff --git a/tests/OpenGraphTests.php b/tests/OpenGraphTests.php
@@ -92,4 +92,18 @@ public function testRenderTags()
         $hmtl = 'HTML: '.$og;
     }
 
-}
+    public function testMbDescription()
+    {
+        $og = $this->getDummy();
+
+        mb_internal_encoding('UTF-8');
+
+        $char = '☺'; // Unicode char U+263A (white smiley)
+
+        $og->description($char, 1);
+        $tag = $og->lastTag('description');
+
+        $this->assertEquals($tag->value, $char);
+    }
+
+}