-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ios course #3
Open
fsaffioti
wants to merge
797
commits into
chrisntr:master
Choose a base branch
from
xamarin:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ios course #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe I have the target SDK stuff setup right, but we'll see. Checking for a front-facing camera is only supported in API Level 9. We still support 8, so we need to have differing minimum and target versions.
- Fixed unauthorized GetPositionAsync error raising in certain scenarios - Fixed disabling permission killing object entirely - Fixed potential constant listen issue
This change is dubious at best, it really just underlines the need to change this API to return UI instead of displaying it automagically.
Also bump version for new release
When GetPositionAsync is called with CancellationToken.None (means, timeout is Timeout.Infinite which is -1) SinglePositionListener does not properly return the requested position.
iOS Unified API support with samples
It is not clear why Android is not returning some of the ids that are requested. This fix will simply skip over any missing ids. Skipping the ids should match the behavior before this commit ea33078
In these 2 cases Mimetype is added to the query but was not checking to see if anything was already there. This will avoid queries where the AND is missing ((mimetype = ?) AND (data2 IS NOT NULL))(mimetype = ?) bad ((mimetype = ?) AND (data2 IS NOT NULL)) AND (mimetype = ?) better
AddressBook class now conflicts with a namespace in Xamarin.iOS. Fixes #45
Bugs 2015 06 08
Fixes issue if you have it set to light as the picker’s is dark.
…be reused Applies to scenarios where the client code uses GetPickPhotoUI/GetTakePhotoUI to generate a view controller instance. The "tcs" field is reset on Dismiss so the same instance can be reused in the navigation controller stack. This enables scenarios where after picking media a custom ViewController is pushed onto the picker's stack, and the user goes "Back" to the picker controllers.
better support for non-standard ContentProviders
Conflicts: MonoDroid/Xamarin.Mobile/Media/MediaPickerActivity.cs
Update SinglePositionListener.cs
Save out and re-set the StatusBarColor
Reset the TaskCompletionSource so the picker instance can be reused
On iOS9 we've had reports of errors in the Delegate setter of PickerViewController which there is an intentional throw to stop users from overriding the delegate and messing with how the view controller was intended to work. It seems in iOS9 something is trying to call the setter with a null value. Not sure if it's a change in our cleanup process (it seems to happen randomly, and after a GC collection occurs) or in iOS itself, but allowing the null value to pass through to the base works around the issue. We can't safeguard the user setting the delegate to null, but presumably if they did this they'd want to set it to some other value after which will still raise an error after this commit achieving the original purpose.
The usage of the provider instance was commented out some time ago, but some references were left to it. This just cleans them up so we don't get a compiler warning anymore.
Also updated designer files for android samples
- Android was building the Debug configuration - Renamed the output zip to have a osx prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ios gps course in continous in MonoTouch/Xamarin.Mobile/Geolocation/Geolocator.cs
and in MonoTouch/Xamarin.Mobile/Geolocation/GeolocationSingleUpdateDelegate.cs