Skip to content

Commit

Permalink
handle dynamic extend in array size check
Browse files Browse the repository at this point in the history
  • Loading branch information
christianrauch committed Jun 21, 2024
1 parent 2b29386 commit 6e60a87
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/CameraNode.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -713,9 +713,12 @@ CameraNode::onParameterChange(const std::vector<rclcpp::Parameter> &parameters)
}

const std::size_t extent = get_extent(id);
if ((value.isArray() && (extent > 0)) && value.numElements() != extent) {
if (value.isArray() &&
(extent != libcamera::dynamic_extent) &&
(value.numElements() != extent))
{
result.successful = false;
result.reason = parameter.get_name() + ": parameter dimensions mismatch, expected " +
result.reason = parameter.get_name() + ": array dimensions mismatch, expected " +
std::to_string(extent) + ", got " + std::to_string(value.numElements());
return result;
}
Expand Down

0 comments on commit 6e60a87

Please sign in to comment.