Prevent control key pass-through when docker is running #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #311. |
christoomey
requested changes
Nov 8, 2022
There was a problem hiding this comment.
Hi @anemator, I appreciate the update here, but unfortunately I'm inclined to not accept as is. The vim detection logic is super complicated and frankly more brittle than I'd like so I'm super cautious about adding additional logic to it.
I would be open to an update to the troubleshooting section describing the issue and suggesting this as a fix, but I don't want to take this on in the core vim detection code unfortunately.
|
No problem. Just updated my branch. Let me know if you need any more changes. |
|
Thanks, @anemator. Merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch we assumed vim would always run on the host system, but docker containers have their own instances of /dev/pts/*, so if vim in say /dev/pts/N was running in tmux which was in a docker container, then we thought vim was running in /dev/pts/N on the host system which caused control keys calls to pass-through as send-keys rather than select-pane on the host system.