Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(template): render html and docx output formats and verify in CI #6

Closed

Conversation

cameronraysmith
Copy link
Contributor

@cameronraysmith cameronraysmith commented Jul 16, 2024

This partially reverts changes to template.qmd from commit 5f26bb4.

Signed-off-by: Cameron Smith <[email protected]>
Signed-off-by: Cameron Smith <[email protected]>
@cameronraysmith cameronraysmith marked this pull request as ready for review July 16, 2024 16:58
@cameronraysmith cameronraysmith force-pushed the end-user-example branch 2 times, most recently from 1cb8c90 to 47470ab Compare July 16, 2024 18:13
- main
pull_request:
types: [opened, synchronize, labeled, reopened]

Copy link
Contributor Author

@cameronraysmith cameronraysmith Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these changes come from a fork, I have executed the workflow there to demonstrate that it works as expected and uploads a copy of all desired artifacts along with each workflow execution

https://github.com/cameronraysmith/nature/actions/runs/9961835354

The zipped artifacts archive containing all template.* now including pdf, html, docx, qmd and tex can be downloaded from
https://github.com/cameronraysmith/nature/actions/runs/9961835354/artifacts/1707559811

Copy link
Contributor Author

@cameronraysmith cameronraysmith Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could split this change into a separate PR to be merged prior to this one and upon which it could be rebased so that we can then verify in this one (#6) that the CI workflow functions as expected for new PRs.

Alternatively, we can imagine this is likely given the results of
https://github.com/cameronraysmith/nature/actions/runs/9961835354 .

template.pdf Outdated Show resolved Hide resolved
@cameronraysmith cameronraysmith changed the title feat(template): render html and docx feat(template): support rendering of html and docx output formats and check this in CI Jul 16, 2024
@cameronraysmith cameronraysmith changed the title feat(template): support rendering of html and docx output formats and check this in CI feat(template): render html and docx output formats and verify in CI Jul 16, 2024
@cameronraysmith
Copy link
Contributor Author

test end-user instantiation from PR fork

~/projects
❯ mkdir test-nature-end-user

~/projects
❯ cd test-nature-end-user

~/projects/test-nature-end-user
❯ quarto use template cameronraysmith/nature@end-user-example

Quarto templates may execute code when documents are rendered. If you do not
trust the authors of the template, we recommend that you do not install or
use the template.
? Do you trust the authors of this template (Y/n) › Yes
? Create a subdirectory for template? (y/N) › No
[✓] Downloading
[✓] Unzipping

The template requires the following changes to extensions:
Nature Journal Template [Install] 1.0.1 (format)
? Would you like to continue (Y/n) › Yes

Preparing template files...
Found 1 extension.

[✓] Copying
[✓] Installing extensions...
[✓] Copying files...

Extensions installed:

  • Nature Journal Template

Files created:

  • bibliography.bib
  • fig.eps
  • fig.pdf
  • test-nature-end-user.qmd

~/projects/test-nature-end-user via ⨁ v1.5.40
❯ bat test-nature-end-user.qmd

...

  28   │ # see: https://quarto.org/docs/extensions/distributing.html#github-distribution
  29   │ csl: _extensions/christopherkenny/nature/csl/springer-basic-brackets-no-et-al.csl
  30   │ author:

...

Signed-off-by: Cameron Smith <[email protected]>
Signed-off-by: Cameron Smith <[email protected]>
orgname/extension instead of extension/orgname

Signed-off-by: Cameron Smith <[email protected]>
@cameronraysmith
Copy link
Contributor Author

Hi @christopherkenny I'm going to close this for now, but let me know if you want to revisit it at some point in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant