Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fixed in missing max-age directive #142

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Typo fixed in missing max-age directive #142

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0206fef
Correct typo in header.go
WKobes Nov 29, 2024
e58b15a
Correct typo in response_test.go
WKobes Nov 29, 2024
4847664
Merge branch 'chromium:main' into typo-patch
WKobes Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion header.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ func preloadableHeaderMaxAge(hstsHeader HSTSHeader, policy preloadlist.PolicyTyp
case hstsHeader.MaxAge == nil:
issues = issues.addErrorf(
"header.preloadable.max_age.missing",
"No max-age directice",
"No max-age directive",
"Header requirement error: Header must contain a valid `max-age` directive.")

case hstsHeader.MaxAge.Seconds < uint64(maxAge):
Expand Down
2 changes: 1 addition & 1 deletion response_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ var responseTests = []struct {
Errors: []Issue{
{Code: "header.preloadable.include_sub_domains.missing", Summary: "No includeSubDomains directive", Message: "The header must contain the `includeSubDomains` directive."},
{Code: "header.preloadable.preload.missing", Summary: "No preload directive", Message: "The header must contain the `preload` directive."},
{Code: "header.preloadable.max_age.missing", Summary: "No max-age directice", Message: "Header requirement error: Header must contain a valid `max-age` directive."},
{Code: "header.preloadable.max_age.missing", Summary: "No max-age directive", Message: "Header requirement error: Header must contain a valid `max-age` directive."},
},
Warnings: []Issue{{Code: "header.parse.empty", Summary: "Empty Header", Message: "The HSTS header is empty."}},
},
Expand Down
Loading