Skip to content

Commit

Permalink
audits: Adds Cantina audit for v2.0.0
Browse files Browse the repository at this point in the history
  • Loading branch information
pmerkleplant committed Nov 27, 2023
1 parent 46f37fe commit 11c7110
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,23 @@ All notable changes to this project will be documented in this file.

The format is based on [Common Changelog](https://common-changelog.org/).

[2.0.0]: https://github.com/chronicleprotocol/scribe/releases/tag/v2.0.0
[1.2.0]: https://github.com/chronicleprotocol/scribe/releases/tag/v1.2.0
[1.1.0]: https://github.com/chronicleprotocol/scribe/releases/tag/v1.1.0
[1.0.0]: https://github.com/chronicleprotocol/scribe/releases/tag/v1.0.0

## [2.0.0] - 2023-11-27

### Changed

- **Breaking** Use 1-byte identifier for feeds based on highest-order byte of their addresses instead of their storage array's index ([#23](https://github.com/chronicleprotocol/scribe/pull/23))
- **Breaking** Change `IScribe` and `IScribeOptimistic` interfaces to account for new feed identification ([#23](https://github.com/chronicleprotocol/scribe/pull/23))

### Fixed

- DOS vector in `ScribeOptimistic::opPoke` making `ScribeOptimistic::opChallenge` economically unprofitable ([#23](https://github.com/chronicleprotocol/scribe/pull/23))
- Possibility to successfully `opChallenge` a valid `opPoke` via non-default calldata encoding ([#23](https://github.com/chronicleprotocol/scribe/pull/23))

## [1.2.0] - 2023-09-29

### Added
Expand Down
Binary file added audits/[email protected]
Binary file not shown.
4 changes: 2 additions & 2 deletions test/IScribeOptimisticTest.sol
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ abstract contract IScribeOptimisticTest is IScribeTest {
opScribe.opPoke(pokeData, schnorrData, ecdsaData);
}

// See audits/Spearbit@v2.0.0.pdf.
// See audits/Cantina@v2.0.0.pdf.
function testFuzz_opPoke_FailsIf_BarNotReached_DueTo_GasAttack(
uint feedIdsLengthSeed
) public {
Expand Down Expand Up @@ -617,7 +617,7 @@ abstract contract IScribeOptimisticTest is IScribeTest {
opScribe.opChallenge(schnorrData);
}

// See audits/Spearbit@v2.0.0.pdf.
// See audits/Cantina@v2.0.0.pdf.
function test_opChallenge_CalldataEncodingAttack() public {
LibFeed.Feed[] memory feeds = _liftFeeds(opScribe.bar());

Expand Down

0 comments on commit 11c7110

Please sign in to comment.