Add RegionPosition class, replace all usages of ChunkPosition as a region with it. #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leMaik
reviewed
Sep 9, 2023
NotStirred
force-pushed
the
refactor/region_position
branch
from
422691d
to
1512cde
Compare
|
Rebased onto master (auto rebase was failing horribly) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have zero impact on performance, but makes things much clearer and adds a nice layer of type safety on top.
I think the name of
ChunkPosition#asRegionPositionis worth discussing. I didn't want to change the return type of the existinggetRegionPositionin case any plugins use it as I'm unsure. Maybe none do?