Implement plugin dependencies, loaded in dependency first order #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotStirred
force-pushed
the
feature/plugin_dependencies
branch
from
2338474
to
2a86ef7
Compare
# Conflicts: # chunky/src/java/se/llbit/chunky/main/Chunky.java
This also makes PluginManager much easier to test.
NotStirred
force-pushed
the
feature/plugin_dependencies
branch
from
2a86ef7
to
7fb0107
Compare
leMaik
reviewed
Sep 23, 2024
leMaik
reviewed
Sep 23, 2024
chunky/src/java/se/llbit/chunky/plugin/loader/JarPluginLoader.java
Outdated
Show resolved
Hide resolved
leMaik
reviewed
Sep 23, 2024
leMaik
requested changes
Sep 23, 2024
|
Yes that is one of the main goals for this PR, do you remember the discussion about having a plugin that would transform 2.4.x plugins to support 2.5.x etc.? That's the main reason |
|
Ah, indeed I do remember this. Allright. 👍 |
leMaik
approved these changes
Sep 24, 2024
|
I added the new dependency to the readme etc. and replaced semver4j with maven-artifact. What do you think about the last two commits, @NotStirred? Edit: maven-artifact depends on org.codehaus.plexus.util 🤔 Why can't we use semver4j or something more lightweight? |
|
Chunky is not and never has been semver, and plugins are almost definitely not either |
|
new commits look good, thanks 👍 maven-artifact is 200KB including all dependencies, that's not unreasonable |
leMaik
force-pushed
the
feature/plugin_dependencies
branch
from
d28d3ea
to
2efacc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't implement a plugin loader API but that is now ready for another PR.
Outstanding things:
org.apache.maven:maven-artifact:3.9.6(Apache 2)