Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated van hummus to muhammara #195

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

sjaakieb
Copy link
Contributor

Changed the dependency from hummus to muhammara(https://github.com/julianhille/MuhammaraJS). Is related to issue #186

@chunyenHuang
Copy link
Owner

Thanks, but I would like to provide the options for both since the repo is designed for hummusJS

@sjaakieb
Copy link
Contributor Author

@chunyenHuang what would be the benefit of that since muhammara is just a fork of hummus?

@chunyenHuang chunyenHuang merged commit a1c9b05 into chunyenHuang:master Aug 11, 2020
@chunyenHuang
Copy link
Owner

2.0.0 start using muhammara

@mhio
Copy link

mhio commented Aug 13, 2020

fyi julianhille/MuhammaraJS#38
I get some odd output from node-pre-gyp on the console after moving to 2.0.0.

this changes julianhille/MuhammaraJS/releases/download/{version}
{node_abi}-{platform}-{arch}-{libc}.tar.gz
{module_name}-v{version}-{node_abi}-{platform}-{arch}.tar.gz

Seems releases might be coming from a dev box rather than CI which is mildy concerning.

@julianhille
Copy link
Collaborator

Yes this is correct the npm publish command is currently issued locally.
Need to setup a github action, sorry for the inconvenience, will try to do that shortly for more transperency and less errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants