ciao-controller: Update internal state after DB state

Ensure consistency by only updating the internal state of the datastore after the datebase state has been updated. Signed-off-by: Rob Bradford <[email protected]>
ciao-project · Nov 22, 2016 · d44c862 · d44c862
1 parent f2d7ca4
commit d44c862
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/ciao-controller/internal/datastore/datastore.go b/ciao-controller/internal/datastore/datastore.go
@@ -1503,12 +1503,6 @@ func (ds *Datastore) CreateStorageAttachment(instanceID string, blockID string,
 		Ephemeral:  ephemeral,
 	}
 
-	// add it to our links map
-	ds.attachLock.Lock()
-	ds.attachments[a.ID] = a
-	ds.instanceVolumes[link] = a.ID
-	ds.attachLock.Unlock()
-
 	err := ds.db.createStorageAttachment(a)
 	if err != nil {
 		return types.StorageAttachment{}, fmt.Errorf("error creating storage attachment: %v", err)
@@ -1528,6 +1522,12 @@ func (ds *Datastore) CreateStorageAttachment(instanceID string, blockID string,
 		return types.StorageAttachment{}, fmt.Errorf("error creating storage attachment: %v", err)
 	}
 
+	// add it to our links map
+	ds.attachLock.Lock()
+	ds.attachments[a.ID] = a
+	ds.instanceVolumes[link] = a.ID
+	ds.attachLock.Unlock()
+
 	return a, nil
 }